feat(accessibility): focus on the last row when user add/remove a row#1285
Draft
feat(accessibility): focus on the last row when user add/remove a row#1285
Conversation
Contributor
|
@MailineN some e2e test fails |
laurentC35
requested changes
Nov 6, 2025
Contributor
laurentC35
left a comment
laurentC35
left a comment
There was a problem hiding this comment.
Can you add a end-to-end test with playwright (read existing test and la doc ) or component test with vitest ?
For a11y feature, i think we have to test it (with e2e test or classic test) by simulate dom event (clicking on button that adding a row and expecting the correct focus)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.