"Listening to", multiple artists, and artist image#37
Merged
Inrixia merged 5 commits intoInrixia:masterfrom Jul 29, 2024
n1ckoates:master
Merged
"Listening to", multiple artists, and artist image#37Inrixia merged 5 commits intoInrixia:masterfrom n1ckoates:master
Inrixia merged 5 commits intoInrixia:masterfrom
n1ckoates:master
Conversation
Owner
|
Waiting on client library support then will merge this once the |
n1ckoates
changed the title
1 task
Owner
|
This is awesome, thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord just added support for the "Listening" activity type, so I switched to that.
Also added support for multiple artists, and added an option (enabled by default) to show the artist's picture as a small image. Tweaked formatting a bit to better suit how Discord displays it.
discord-rpcdoesn't support activity types yet, so this pull request depends on discordjs/RPC#149.You can patch
discord-rpcto get this working right now: add another line below line 520 ofnode_modules/discord-rpc/src/client.js, with the contents