nix: migrate fetchPnpmDeps

[Desoroxxx]

This fixes a warning see: NixOS/nixpkgs#494184

Did not do it for Darwin as I do not have access to that platform.

[Inrixia]

Could you do it for all platforms anyway? If it breaks something can revert

[Desoroxxx]

Could you do it for all platforms anyway? If it breaks something can revert

I am still new to nix so I might be completely wrong here, but as far as I know there is no real way for me to actually do it, I won't be able to get the real hash and it will simply fail.

[Inrixia]

Ah, @ojsef39, @frostplexx, @xaiyadev

[xaiyadev]

You can get the hash on linux too.
If nobody touches this until this evening I will fix it up ^^

Also: you could just change the fetcherversion, then push it and the pipeline will update the hash itself

[frostplexx]

The same treatment is needed for Darwin too. Although I think you need macOS to generate its pnpm hash?

I can open a separate PR that applies the same change to Darwin if @Desoroxxx is unable to do it :)

[Desoroxxx]

You can get the hash on linux too. If nobody touches this until this evening I will fix it up ^^

How? I tried looking but haven't found anything like that or at least it wasn't really clear, I am fine with you pointing to a doc page.

Also: you could just change the fetcherversion, then push it and the pipeline will update the hash itself

Oh well, that simplifies things lol

[Desoroxxx]

If the pipeline does update the hash it should just work for both now

[Inrixia]

Happy to merge this once it's been resolved. I don't use nix so can't help much here 💜

[frostplexx]

LGTM then

[Inrixia]

Good to merge?

[xaiyadev]

Is there a way to a run a test pipeline kn this branch?
Not really familiar with github actions but I know this is possible on bitbucket, could we maybe try that first?

Oterwise LGTM

[Inrixia]

Someone should do a seperate pr to add a workflow to run the build and tests on pr changes.

Otherwise it won't run atm.

I think technically @Desoroxxx could try manually run on their branch but I wouldn't reccomend it over the solution above.

[ojsef39]

Someone should do a seperate pr to add a workflow to run the build and tests on pr changes.

#142 would be ready to merge now, if you are still interested in having that :)

[Inrixia]

Idk how to trigger the checks to run without the pr changing...

[ojsef39]

ig @Desoroxxx has to rebase/update branch so it will trigger the action?

i could also just add a workflow input real quick so you can trigger it manually

[Inrixia]

Workflow input would be appreciated.

Also see my comment on #142, would be great to have a manual trigger available for the build workflow too.

Though I'm not familiar with how manual triggers are invoked on PR's. Does it just add a UI button?

[ojsef39]

Though I'm not familiar with how manual triggers are invoked on PR's. Does it just add a UI button?

Im not sure actually if that will work since the branch doesnt belong to this repo technically, but i would be shown like this:

[Inrixia]

Yea I don't think itl work then. Annoying, I wish GitHub just gave a way to run in or manually. Ah well

[Inrixia]

I can always try this

[Inrixia]

Nop

[Inrixia]

Itl need a force push or change to trigger then

[Inrixia]

If it's gonna be too much of a PITA idm just merging this if everyone feels it won't have issues.

[xaiyadev]

Only issue could be that the nix-darwin hash wont be fixed anymore

But then also, its a problem of the pipeline itself cuz it should update the hash, and then the pipeline has to be fixed

So we have to try out eitherway
Because of that I dont mind merging it already

[Inrixia]

Eh, whatever, can always pr a fix if it doesn't capture everything.

Lets send it