Open
Conversation
The Plugin Manager now supports depending on librarys. Library plugins get automatically installed when a plugin depends on them.
Plugins now have the (optional) field added to the package.json:
luna: {
type: "plugin OR library",
dependencies: [
{
"name":"" // package name of the library plugin
"storeUrl":"" // url of the store the plugin can be downloaded from, in case the store is not present already
"devStoreUrl":"" // Store the library plugin is downloaded when from loading a plugin via the localhost dev store.
]
}
Library plugins only need the type field. Normal plugins need the rest. If a plugin does not need to depend on others, adding the luna field is optional.
If a package name is added under the luna dependencies, the compiler will now automatically treat it as external and won't compile it into the plugin.
Owner
|
This looks pretty thick and implements a major feature so it may take a bit of time for me to review 💜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Plugin Manager now supports depending on librarys. Library plugins get automatically installed when a plugin depends on them.
Plugins have the (optional) field added to the package.json:
luna: { type: "plugin OR library", dependencies: [ { "name":"" // package name of the library plugin "storeUrl":"" // url of the store the plugin can be downloaded from, in case the store is not present already "devStoreUrl":"" // Store the library plugin is downloaded when from loading a plugin via the localhost dev store. } ] }Library plugins only need the type field. Normal plugins need the rest. If a plugin does not need to depend on others, adding the luna field is optional.
If a package name is added under the luna dependencies, the compiler will now automatically treat it as external and won't compile it into the plugin.