Add NoDiscard attribute on mutation free methods and the ones returning monads

psalm.xml

@@ -14,4 +14,7 @@
             <directory name="vendor" />
         </ignoreFiles>
     </projectFiles>
+    <issueHandlers>
+        <UndefinedAttributeClass errorLevel="suppress" />
+    </issueHandlers>
 </psalm>

src/Control.php

@@ -19,6 +19,7 @@ private function __construct(
     ) {
     }
 
+    #[\NoDiscard]
     public static function of(Server $server): self
     {
         return new self(
@@ -28,16 +29,19 @@ public static function of(Server $server): self
         );
     }
 
+    #[\NoDiscard]
     public function users(): Users
     {
         return $this->users;
     }
 
+    #[\NoDiscard]
     public function vhosts(): VHosts
     {
         return $this->vhosts;
     }
 
+    #[\NoDiscard]
     public function permissions(): Permissions
     {
         return $this->permissions;

src/Control/Permissions.php

@@ -20,6 +20,7 @@ private function __construct(
     ) {
     }
 
+    #[\NoDiscard]
     public static function of(Server $server): self
     {
         return new self($server, Command::foreground('rabbitmqadmin'));
@@ -28,6 +29,7 @@ public static function of(Server $server): self
     /**
      * @return Attempt<SideEffect>
      */
+    #[\NoDiscard]
     public function declare(
         string $vhost,
         string $user,
@@ -58,6 +60,7 @@ public function declare(
     /**
      * @return Attempt<SideEffect>
      */
+    #[\NoDiscard]
     public function delete(string $vhost, string $user): Attempt
     {
         return $this

src/Control/Users.php

@@ -20,6 +20,7 @@ private function __construct(
     ) {
     }
 
+    #[\NoDiscard]
     public static function of(Server $server): self
     {
         return new self($server, Command::foreground('rabbitmqadmin'));
@@ -28,6 +29,7 @@ public static function of(Server $server): self
     /**
      * @return Attempt<SideEffect>
      */
+    #[\NoDiscard]
     public function declare(string $name, string $password, string ...$tags): Attempt
     {
         return $this
@@ -51,6 +53,7 @@ public function declare(string $name, string $password, string ...$tags): Attemp
     /**
      * @return Attempt<SideEffect>
      */
+    #[\NoDiscard]
     public function delete(string $name): Attempt
     {
         return $this

src/Control/VHosts.php

@@ -20,6 +20,7 @@ private function __construct(
     ) {
     }
 
+    #[\NoDiscard]
     public static function of(Server $server): self
     {
         return new self($server, Command::foreground('rabbitmqadmin'));
@@ -28,6 +29,7 @@ public static function of(Server $server): self
     /**
      * @return Attempt<SideEffect>
      */
+    #[\NoDiscard]
     public function declare(string $name): Attempt
     {
         return $this
@@ -49,6 +51,7 @@ public function declare(string $name): Attempt
     /**
      * @return Attempt<SideEffect>
      */
+    #[\NoDiscard]
     public function delete(string $name): Attempt
     {
         return $this

src/Model/Channel.php

@@ -38,6 +38,7 @@ private function __construct(
      *
      * @param Maybe<PointInTime> $idleSince
      */
+    #[\NoDiscard]
     public static function of(
         Name $name,
         VHost\Name $vhost,
@@ -66,51 +67,61 @@ public static function of(
         );
     }
 
+    #[\NoDiscard]
     public function name(): Name
     {
         return $this->name;
     }
 
+    #[\NoDiscard]
     public function vhost(): VHost\Name
     {
         return $this->vhost;
     }
 
+    #[\NoDiscard]
     public function user(): User\Name
     {
         return $this->user;
     }
 
+    #[\NoDiscard]
     public function number(): int
     {
         return $this->number;
     }
 
+    #[\NoDiscard]
     public function node(): Node\Name
     {
         return $this->node;
     }
 
+    #[\NoDiscard]
     public function state(): State
     {
         return $this->state;
     }
 
+    #[\NoDiscard]
     public function messages(): Messages
     {
         return $this->messages;
     }
 
+    #[\NoDiscard]
     public function consumers(): Count
     {
         return $this->consumers;
     }
 
+    #[\NoDiscard]
     public function confirm(): bool
     {
         return $this->confirm;
     }
 
+    #[\NoDiscard]
     public function transactional(): bool
     {
         return $this->transactional;
@@ -119,6 +130,7 @@ public function transactional(): bool
     /**
      * @return Maybe<PointInTime>
      */
+    #[\NoDiscard]
     public function idleSince(): Maybe
     {
         return $this->idleSince;

src/Model/Channel/Messages.php

@@ -20,6 +20,7 @@ private function __construct(
     /**
      * @psalm-pure
      */
+    #[\NoDiscard]
     public static function of(
         Count $uncommitted,
         Count $unconfirmed,
@@ -28,16 +29,19 @@ public static function of(
         return new self($uncommitted, $unconfirmed, $unacknowledged);
     }
 
+    #[\NoDiscard]
     public function uncommitted(): Count
     {
         return $this->uncommitted;
     }
 
+    #[\NoDiscard]
     public function unconfirmed(): Count
     {
         return $this->unconfirmed;
     }
 
+    #[\NoDiscard]
     public function unacknowledged(): Count
     {
         return $this->unacknowledged;

src/Model/Channel/Name.php

@@ -15,11 +15,13 @@ private function __construct(private string $value)
     /**
      * @psalm-pure
      */
+    #[\NoDiscard]
     public static function of(string $value): self
     {
         return new self($value);
     }
 
+    #[\NoDiscard]
     public function toString(): string
     {
         return $this->value;

src/Model/Connection.php

@@ -43,6 +43,7 @@ private function __construct(
     /**
      * @psalm-pure
      */
+    #[\NoDiscard]
     public static function of(
         Name $name,
         PointInTime $connectedAt,
@@ -77,71 +78,85 @@ public static function of(
         );
     }
 
+    #[\NoDiscard]
     public function name(): Name
     {
         return $this->name;
     }
 
+    #[\NoDiscard]
     public function connectedAt(): PointInTime
     {
         return $this->connectedAt;
     }
 
+    #[\NoDiscard]
     public function timeout(): Timeout
     {
         return $this->timeout;
     }
 
+    #[\NoDiscard]
     public function vhost(): VHost\Name
     {
         return $this->vhost;
     }
 
+    #[\NoDiscard]
     public function user(): User\Name
     {
         return $this->user;
     }
 
+    #[\NoDiscard]
     public function protocol(): Protocol
     {
         return $this->protocol;
     }
 
+    #[\NoDiscard]
     public function authenticationMechanism(): AuthenticationMechanism
     {
         return $this->authenticationMechanism;
     }
 
+    #[\NoDiscard]
     public function ssl(): bool
     {
         return $this->ssl;
     }
 
+    #[\NoDiscard]
     public function peer(): Peer
     {
         return $this->peer;
     }
 
+    #[\NoDiscard]
     public function host(): Host
     {
         return $this->host;
     }
 
+    #[\NoDiscard]
     public function port(): Port
     {
         return $this->port;
     }
 
+    #[\NoDiscard]
     public function node(): Node\Name
     {
         return $this->node;
     }
 
+    #[\NoDiscard]
     public function type(): Type
     {
         return $this->type;
     }
 
+    #[\NoDiscard]
     public function state(): State
     {
         return $this->state;

src/Model/Connection/AuthenticationMechanism.php

@@ -15,6 +15,7 @@ enum AuthenticationMechanism
     /**
      * @psalm-pure
      */
+    #[\NoDiscard]
     public static function of(string $value): self
     {
         return match ($value) {
@@ -24,6 +25,7 @@ public static function of(string $value): self
         };
     }
 
+    #[\NoDiscard]
     public function toString(): string
     {
         return match ($this) {

src/Model/Connection/Name.php

@@ -15,11 +15,13 @@ private function __construct(private string $value)
     /**
      * @psalm-pure
      */
+    #[\NoDiscard]
     public static function of(string $value): self
     {
         return new self($value);
     }
 
+    #[\NoDiscard]
     public function toString(): string
     {
         return $this->value;

src/Model/Connection/Peer.php

@@ -22,16 +22,19 @@ private function __construct(
     /**
      * @psalm-pure
      */
+    #[\NoDiscard]
     public static function of(Host $host, Port $port): self
     {
         return new self($host, $port);
     }
 
+    #[\NoDiscard]
     public function host(): Host
     {
         return $this->host;
     }
 
+    #[\NoDiscard]
     public function port(): Port
     {
         return $this->port;

src/Model/Connection/Protocol.php

@@ -16,6 +16,7 @@ enum Protocol
     /**
      * @psalm-pure
      */
+    #[\NoDiscard]
     public static function of(string $value): self
     {
         return match ($value) {

src/Model/Connection/Timeout.php

@@ -20,6 +20,7 @@ private function __construct(private int $value)
      *
      * @param int<0, max> $value
      */
+    #[\NoDiscard]
     public static function of(int $value): self
     {
         return new self($value);
@@ -28,6 +29,7 @@ public static function of(int $value): self
     /**
      * @return int<0, max>
      */
+    #[\NoDiscard]
     public function toInt(): int
     {
         return $this->value;