Apply structured output formatter to setup execution#4
Merged
DylanBlakemore merged 2 commits intomainfrom Apr 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fmt.Printfcalls inExecutor.Executewith the structuredoutput.FormatterDetails
This wires up the
output.Formatter(created in #3) into the setup executor. Instead of flat[phase] steplines and emoji-based status messages, the executor now emits structured phase blocks withPhaseStart/PhaseEndboundaries, shows step durations inline viaStepSuccess/StepFailure, displays failing command stderr indented beneath the step, and lists skipped phases at the bottom when execution fails early. A newNewExecutorWithFormatterconstructor supports dependency injection for testing. Tests now use a buffer-backed plain-text formatter for deterministic assertions, and two new test cases cover stderr display and skipped phase output.