Skip to content

Apply structured output formatter to setup execution#4

Merged
DylanBlakemore merged 2 commits intomainfrom
apply-formatter-to-setup-execution
Apr 3, 2026
Merged

Apply structured output formatter to setup execution#4
DylanBlakemore merged 2 commits intomainfrom
apply-formatter-to-setup-execution

Conversation

@DylanBlakemore
Copy link
Copy Markdown
Collaborator

Summary

  • Replace raw fmt.Printf calls in Executor.Execute with the structured output.Formatter
  • Add phase lifecycle tracking, per-step durations, stderr on failure, and skipped phase reporting
  • Update all executor and runner tests to match new output format

Details

This wires up the output.Formatter (created in #3) into the setup executor. Instead of flat [phase] step lines and emoji-based status messages, the executor now emits structured phase blocks with PhaseStart/PhaseEnd boundaries, shows step durations inline via StepSuccess/StepFailure, displays failing command stderr indented beneath the step, and lists skipped phases at the bottom when execution fails early. A new NewExecutorWithFormatter constructor supports dependency injection for testing. Tests now use a buffer-backed plain-text formatter for deterministic assertions, and two new test cases cover stderr display and skipped phase output.

@DylanBlakemore DylanBlakemore merged commit f13ffd4 into main Apr 3, 2026
7 checks passed
@DylanBlakemore DylanBlakemore deleted the apply-formatter-to-setup-execution branch April 3, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant