feat: add a nix flake and a home-manager module#12
Conversation
added 5 commits
October 27, 2024 17:57
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was tested with:
danid3v-nix-refactorbranch for the main home-manager moduleIf you want to see the available templates (in nix at least) you can run the following (you need the
nix-commandfeature and jq):Notes:
hm module interface:
programs.matugen-themes.presetsis limited to a list of strings(e.g.[ "hypr" "gtk3" ]). You can use the name of any template in this repo, except for 2 things that have been changed(the only hardcoded things on the nix side):hyprlandandhyprlocktemplates were merged into a singlehyproneNote: I know that the file would be overwritten if they don't home-manager. IDK if it will still happen if they use home-manager for starship in the first place
Up for debate
Should the option be moved to
programs.matugen.enabledPresetsor something else?readme parsing
nix/parseReadme.nixuses regexes to parse the readme. It should keep working as-is until you add an entry under midnight-discord.Regex explanations on regex101.com
builtins.match ".*output_path = '([^']+)'.*" section(line 57)builtins.match "([^\n]+).*" section(line 75)Manual work on the end-user's side
They need to know what programs are run in the
post_hooks that they are using and place them inprograms.matugen.extraPackages, at least after # 68 over at matugen is merged with some variant of my suggestionsA simple
realpath $(which <cmd>)should suffice