Conversation
| export interface Emplyee{ | ||
| id:number; | ||
| name:string; | ||
| description:string; |
There was a problem hiding this comment.
make name of file start by small character.
employee doesn't have description it have company --> get it from swagger.
| }) | ||
| export class MessageService { | ||
| delete(id: number) { | ||
| throw new Error('Method not implemented.'); |
There was a problem hiding this comment.
why you made this function?
|
|
||
| constructor( | ||
| private formBuilder: FormBuilder, | ||
| private _EmployeeRepository: EmployeeRepository, |
There was a problem hiding this comment.
name must be camel case.
| companyId:['', [Validators.required]] | ||
| } | ||
| addEmployee(){ | ||
| this._EmployeeRepository.update(this.employeeForm.value).subscribe(()=>{ |
There was a problem hiding this comment.
this function add not update
| .subscribe((result) => { | ||
| this.allEmployees = result.data; | ||
| this.totalItems = result.pagination.itemCount; | ||
| console.log(result) |
| }) | ||
| }) | ||
| } | ||
| onSubmit() {} |
There was a problem hiding this comment.
delete unneeded function.
| this.isVisible = !this.isVisible; | ||
| } | ||
| appearRest() { | ||
| this.isRestButtonAppear = true; |
There was a problem hiding this comment.
are you need this function?
| <mat-option value="over">Over</mat-option> | ||
| <mat-option value="push">Push</mat-option> | ||
| <mat-option value="Education">Education</mat-option> | ||
| <mat-option value="Government">Government</mat-option> |
There was a problem hiding this comment.
use endpoint of company(get it from swagger) to show data in dropdown list
don't make it static
| export interface emplyee{ | ||
| id:number; | ||
| name:string; | ||
|
|
There was a problem hiding this comment.
from swagger you can get the object of employee property
where property of company?
| totalItems: number = 0; | ||
|
|
||
| constructor(private formBuilder: FormBuilder, private companyRepository: CompanyRepository,private message: MessageService) { } | ||
| constructor(private FormBuilder: FormBuilder, private companyRepository: CompanyRepository,private message: MessageService) { } |
There was a problem hiding this comment.
make FormBuilder ---> camel case
| size: number = 10; | ||
| totalItems: number = 0; | ||
| allEmployees: emplyee[] = []; | ||
| isRestButtonAppear: boolean; |
There was a problem hiding this comment.
delete un need property
| this.employeeForm = this.formBuilder.group({ | ||
| id: [''], | ||
| name: ['', [Validators.required]], | ||
| companyId: ['', [Validators.required]], |
There was a problem hiding this comment.
it will be same of interface company not companyId
2 participants
No description provided.