Open
Conversation
Contributor
hossamgomaa24
left a comment
hossamgomaa24
left a comment
There was a problem hiding this comment.
method "update" update the name without validation
| } | ||
|
|
||
| public ResponseEntity<?> save(PositionDto dto) { | ||
| Optional<Position> positionByName = positionService.getByName(dto.getName()); |
Contributor
There was a problem hiding this comment.
is exictedName better or positionByName?
Contributor
Noorhan-Khaled
left a comment
Noorhan-Khaled
left a comment
There was a problem hiding this comment.
Where is validation in update?
| } | ||
|
|
||
| public ResponseEntity<?> save(PositionDto dto) { | ||
| Optional<Position> existingPositionName = positionService.getByName(dto.getName()); |
Contributor
There was a problem hiding this comment.
ليه بتضيفى position احنا موجودين فى positionHandler يبقى هيكون exsistesdName لانه كده معروف انه name ده بتاع position
| public ResponseEntity<?> update(Integer id, PositionDto dto){ | ||
| Position position = positionService.getById(id). | ||
| orElseThrow(() -> new ResourceNotFoundException(Position.class.getSimpleName(), id)); | ||
| Optional<Position> existingPositionName = positionService.getByName(dto.getName()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.