Open
Conversation
vogti
requested changes
Nov 19, 2023
Contributor
vogti
left a comment
vogti
left a comment
There was a problem hiding this comment.
The hash seems to be unknown. Did you use your university mail address?
Author
|
Yes I did. Using zsh the hash created is not in the in the hashes.txt file. I've seen that you already made a change in the submit.sh script prompting the user to use bash. Using bash the outcoming hash is indeed in the file. So I'll make another commit. |
vogti
requested changes
Nov 20, 2023
Contributor
vogti
left a comment
vogti
left a comment
There was a problem hiding this comment.
It is interesting that the hash differs depending on the Shell being used, especially that zsh vs. bash makes a difference. However, the script has a hashbang indicating that it should be executed using bash.
The hash is now valid, but you have deleted the .gitkeep file. Please undo this and it should be fine to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.