Skip to content

Conversation

@NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Jan 16, 2026

Closes 186

Proposed Changes

  • Move filter of non-HTTP kwargs straight into WriteApi._post_write() function.
  • Add test cases for write dataframe with batch, and write file with batch.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 added this to the 0.17.0 milestone Jan 16, 2026
@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Jan 16, 2026
@NguyenHoangSon96 NguyenHoangSon96 marked this pull request as draft January 16, 2026 04:07
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.37%. Comparing base (1b71b6a) to head (69b467f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   70.20%   70.37%   +0.16%     
==========================================
  Files          35       35              
  Lines        2356     2356              
==========================================
+ Hits         1654     1658       +4     
+ Misses        702      698       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NguyenHoangSon96 NguyenHoangSon96 marked this pull request as ready for review January 16, 2026 07:17
@NguyenHoangSon96 NguyenHoangSon96 changed the title feat: add support for writing Pandas DataFrames with tests fix: write data frame and write file with batch Jan 16, 2026
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for PR 👍. There are only one minor requirement:

Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@NguyenHoangSon96 NguyenHoangSon96 merged commit 56e2b13 into main Jan 16, 2026
16 checks passed
@NguyenHoangSon96 NguyenHoangSon96 deleted the fix/write-batch-dataframe branch January 16, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

data_frame_tag_columns broken with batched writes in 0.17

3 participants