Conversation
Added a Info box about limitation row 203-207 Also, added an additional explanation in line 170
simonhbor
left a comment
There was a problem hiding this comment.
Looks good in general - some typos and small corrections
docs/Developers/API-Overview.md
Outdated
|
|
||
| - **start_row** : The record starting number. This parameter starts at 1. | ||
| - **number_of_rows** : The maximum number of records to return. The bigger the number, the more time it takes for the request to be processed. If you are seeing timeout errors, reduce this value and make more requests to retrieve the data. | ||
| - **number_of_rows** : The maximum number of records to return. The bigger the number, the more time it takes for the request to be processed. If you are seeing timeout errors, reduce this value and make more requests to retrieve the data. Note, that currently there is a limiteation so the maximum allowed number of rows per single API call is 500. |
There was a problem hiding this comment.
Please fix the typo for "limiteation"
| [] | ||
| ``` | ||
|
|
||
| !!! info Limitation |
There was a problem hiding this comment.
Correct syntax should be !!! info "Limitation"
There was a problem hiding this comment.
This needs to be exactly as I said it above. You need the " " around the word Limitation
|
|
||
| !!! info Limitation | ||
| Currently, there is a limitation for the allowed number of rows that can be retrieved per single API GET query at a time. That is a design limit to protect the system from a performance perspective, typical for web applications. The maximum number of rows you can get by a single GET request is 500, for general API endpoints. | ||
| Considering this, make multiple GET requests (use pagination options) so the number of rows does not exceed that limit. |
There was a problem hiding this comment.
You need to add an empty line between paragraphs (not required for bullets but is for paragraphs)
| ``` | ||
|
|
||
| !!! info Limitation | ||
| Currently, there is a limitation for the allowed number of rows that can be retrieved per single API GET query at a time. That is a design limit to protect the system from a performance perspective, typical for web applications. The maximum number of rows you can get by a single GET request is 500, for general API endpoints. |
There was a problem hiding this comment.
IN per single API GET query at a time remove the GET as I think the limit applies to POST too. Do the same later in the sentence and in the paragraph below
There was a problem hiding this comment.
Done all three PRs.
Hope this time all of them correct.
Sorry for extra time.
Replaced incorrect Atlassian login with DevOps login on line 27
simonhbor
left a comment
There was a problem hiding this comment.
Something went wrong here - there are git lines included, and there are outstanding syntax fixes to do.
| [] | ||
| ``` | ||
|
|
||
| !!! info Limitation |
There was a problem hiding this comment.
This needs to be exactly as I said it above. You need the " " around the word Limitation
| - **start_row** : The record starting number. This parameter starts at 1. | ||
| - **number_of_rows** : The maximum number of records to return. The bigger the number, the more time it takes for the request to be processed. If you are seeing timeout errors, reduce this value and make more requests to retrieve the data. Note, that currently there is a limiteation so the maximum allowed number of rows per single API call is 500. | ||
| - **number_of_rows** : The maximum number of records to return. The bigger the number, the more time it takes for the request to be processed. If you are seeing timeout errors, reduce this value and make more requests to retrieve the data. | ||
| Note, that currently there is a limitation so the maximum allowed number of rows per single API call is 500. |
There was a problem hiding this comment.
You need to add an empty line here and outdent, or you need to include it as part of line 170
| [] | ||
| ``` | ||
|
|
||
| <<<<<<< Updated upstream |
|
|
||
| ======= | ||
| !!! info "Limitation" | ||
| Currently, there is a limitation for the allowed number of rows that can be retrieved per single API query at a time. That is a design limit to protect the system from a performance perspective, typical for web applications. The maximum number of rows you can get by a single GET request is 500, for general API endpoints. |
| ======= | ||
| !!! info "Limitation" | ||
| Currently, there is a limitation for the allowed number of rows that can be retrieved per single API query at a time. That is a design limit to protect the system from a performance perspective, typical for web applications. The maximum number of rows you can get by a single GET request is 500, for general API endpoints. | ||
| Considering this, make multiple GET requests (use pagination options) so the number of rows does not exceed that limit. |
There was a problem hiding this comment.
You need an empty line between paragraphs
| Currently, there is a limitation for the allowed number of rows that can be retrieved per single API query at a time. That is a design limit to protect the system from a performance perspective, typical for web applications. The maximum number of rows you can get by a single GET request is 500, for general API endpoints. | ||
| Considering this, make multiple GET requests (use pagination options) so the number of rows does not exceed that limit. | ||
|
|
||
| >>>>>>> Stashed changes |
Added a Info box about limitation row 203-207
Also, added an additional explanation in line 170