-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Stopwatch: add persistence #1410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stopwatch: add persistence #1410
Conversation
Stopwatch now keeps running in background if screen is left. Implemented this by introducing a StopWatchController. Largely based on the work of Louis Pearson (@desttinghim@github.com), see InfiniTimeOrg#783
StopWatchController was introduced with InfiniTimeOrg/InfiniTime#1410
c76d547 to
071f09d
Compare
|
Cool! Glad to see this is getting completed. I started working on rebasing it but I didn't want to get a build environment set up - thank you for taking it on 🙂 |
minacode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this feature. I scrolled through and found some things regarding code style. They are mostly functions starting with a lowercase character. I may not have found all of them.
|
Those are probably leftover from the work I did |
Co-authored-by: Max Friedrich <minacode@users.noreply.github.com>
Co-authored-by: Max Friedrich <minacode@users.noreply.github.com>
Co-authored-by: Max Friedrich <minacode@users.noreply.github.com>
Co-authored-by: Elements6007 <Elements6007@gmail.com>
|
Thank you all for taking a look on it. I think I applied all proposals, and found no further lowercase-functions. |
|
What about those struct types that end with |
I checked other structs by running |
|
Any chance of this getting rebased against |
|
Good news: #2141 is merged now :) |
Stopwatch now keeps running in background if screen is left.
Implemented this by introducing a StopWatchController.
In additon, now an infinite lap count is possible (but only two laps are stored).
Largely based on the work of Louis Pearson (@desttinghim), see #783. Nevertheless, I removed all changes not related to the stopwatch persistence feature.
The corresponding PR to InfiniSim (for adding the StopWatchController) is InfiniTimeOrg/InfiniSim#75.
Would close #303.