Skip to content

Persistent Nicknames #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keanbarz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Persistent Nicknames #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 54 additions & 1 deletion BP/scripts/commands/list/nickname.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,70 @@ const commandInformation = {
]
}

const NICK_PROP = "nickname";

/* 1️⃣ Register dynamic property (safe way) */
let registered = false;

world.afterEvents.playerSpawn.subscribe(ev => {
if (registered) return;
registered = true;

world.propertyRegistry.registerString(NICK_PROP, 64);
});

/* ─────────────────────────────
2️⃣ Nickname helpers
───────────────────────────── */
/*function getNickname(player) {
return player.getDynamicProperty(NICK_PROP);
}*/

function setNickname(player, nickname) {
player.setDynamicProperty(NICK_PROP, nickname);
player.nameTag = nickname;
}

/* ─────────────────────────────
3️⃣ Re-apply nickname on join
───────────────────────────── */
world.afterEvents.playerSpawn.subscribe(ev => {
if (!ev.initialSpawn) return;

const player = ev.player;
const nickname = player.getDynamicProperty(NICK_PROP);

if (nickname) {
player.nameTag = nickname;
}
});

/* ─────────────────────────────
4️⃣ Chat interception
───────────────────────────── */
world.beforeEvents.chatSend.subscribe(ev => {
const player = ev.sender;
const nickname = player.getDynamicProperty(NICK_PROP) || player.name;

ev.cancel = true;
world.sendMessage(`${nickname}${':'} §r${ev.message}`);
});

if(config.commands.allowCommands.nickname) {
registerCommand(commandInformation, (origin, target, nickname) => {
const executor = origin?.sourceEntity
if(target.length === 0) return logReply(executor, "§cCould not find that player")

if (nickname.length > 24)
return logReply(executor, "§cNickname too long");
nickname = nickname.replace(/§k/g, "");

// For @a
let players = []
for(const p of target) {
const player = world.getPlayers().find(player => player.id === p.id)
players.push(player)
system.run(() => player.nameTag = nickname);
system.run(() => setNickname(player, nickname));
}

players.length > 1 ? logReply(executor, `§eYou have successfully changed everyone's nickname`) : logReply(executor, `§eYou have successfully changed ${players[0].name}'s nickname`)
Expand Down