Skip to content

correct way to handle processid #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
levhitaIncode wants to merge 2 commits into
base: main
Choose a base branch
from
Open

correct way to handle processid #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6f35cf
correct way to handle processid
levhitaIncode Jun 25, 2025
06bfee1
Merge branch 'main' into fix-on-processid
levhitaIncode Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,13 @@ function captureId() {

// 5.- Process the ID
async function processId() {
const results = await incode.processId({
token: incodeSession.token,
});
console.log("processId results", results);
captureSelfie();
return incode.processId({ token: incodeSession.token })
.then(() => {
captureSelfie();
})
.catch((error) => {
showError(error);
});
Comment on lines +75 to +81
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The refactoring from async/await to Promise chaining reduces readability without clear benefit. The async/await pattern was more readable and the original code was missing error handling, which could have been added with a try/catch block instead.

Suggested change
return incode.processId({ token: incodeSession.token })
.then(() => {
captureSelfie();
})
.catch((error) => {
showError(error);
});
try {
await incode.processId({ token: incodeSession.token });
captureSelfie();
} catch (error) {
showError(error);
}

Copilot uses AI. Check for mistakes.
}

// 6.- Capture the selfie
Expand Down