Skip to content

ISSUE-14 Fix layout flaws in the German version#17

Open
christophdubach wants to merge 2 commits intoInclusive-Design-Principles:mainfrom
christophdubach:bugfix/ISSUE-14_de-layout-flaws
Open

ISSUE-14 Fix layout flaws in the German version#17
christophdubach wants to merge 2 commits intoInclusive-Design-Principles:mainfrom
christophdubach:bugfix/ISSUE-14_de-layout-flaws

Conversation

@christophdubach
Copy link
Copy Markdown

@christophdubach christophdubach commented Mar 30, 2024

Fixes #14

  • Limited the <h1> width to prevent text and image overlapping
  • Updated the in-page nav CSS selector to add the styling to the German variant
  • Added missing umlauts to the Google font params
  • Allowed long words to be broken with a soft hyphen

Comment thread css/style.css

nav[aria-label="page"] {
nav[aria-label="page"],
nav[aria-label="Seite"] {
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See issue #18

@LJWatson
Copy link
Copy Markdown
Contributor

LJWatson commented Apr 3, 2024

Thank you @christophdubach.

@IanPouncey or @Heydon could you review this PR when you get a moment possibly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

German Translation Website Layout Errors

2 participants