ci: give fork PRs Linux CI — run them in the rolling ci-main image#554
Merged
Conversation
Fork PRs get a read-only GITHUB_TOKEN (no packages:write), so the dev-image job's GHCR login/push failed — and because every Linux leg runs inside that image via needs+container, all of them skipped. Fork PRs (first one: #553) effectively had no Linux CI; never noticed because there had never been one. dev-image now skips login/push on fork PRs and points the Linux legs at a rolling ci-main tag that every main push publishes alongside its ci-<sha> tag: same toolchain, just not rebuilt from the PR's Dockerfile (a fork PR editing .devcontainer/Dockerfile still tests with the base image — push its branch to origin to exercise that). Same-repo PRs and main pushes behave exactly as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork PRs get a read-only GITHUB_TOKEN (no packages:write), so the
dev-image job's GHCR login/push failed — and because every Linux leg
runs inside that image via needs+container, all of them skipped. Fork
PRs (first one: #553) effectively had no Linux CI; never noticed
because there had never been one.
dev-image now skips login/push on fork PRs and points the Linux legs
at a rolling ci-main tag that every main push publishes alongside its
ci- tag: same toolchain, just not rebuilt from the PR's
Dockerfile (a fork PR editing .devcontainer/Dockerfile still tests
with the base image — push its branch to origin to exercise that).
Same-repo PRs and main pushes behave exactly as before.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com