feat: Line Confidence Chart: Enhanced Zooming and Interaction #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced an option to filter data in the Chart component based on parametric upper and lower bounds, improving data accuracy in visualizations. - Updated max and min calculations to conditionally use filtered values, enhancing the overall functionality of the chart. - Refactored TimeSeriesGraph layout for better responsiveness and user experience.
…cales - Enhanced error messages in LineConfidenceChart to provide specific feedback when scales, paths, or axis ticks are unavailable. - Updated useChartScales to check for undefined values in xExtent and yExtent, improving robustness in scale calculations. - Adjusted Chart component to conditionally use maxValueChart for min-max calculations, ensuring accurate data representation. - Introduced state management for maxValueChart and minValueChart in LineConfidenceContext to streamline data handling.
…g and user interaction - Updated Chart component to adjust min-max calculations, ensuring more accurate data representation. - Introduced aggregation interval selection in Controls component, allowing users to choose from various time intervals for data aggregation. - Improved error handling in LineConfidenceContext to set aggregation interval only when data is available, enhancing robustness.
…roved data handling - Removed unused OverviewChart import and showAreaOverview prop from LineConfidenceChart. - Adjusted xFormatter logic in LineConfidenceChart to conditionally use xFormatterOverview based on showLineOverview. - Enhanced MainChart to accept showLineOverview prop, allowing for conditional rendering of the zoom container. - Updated event handling in MainChart to prevent event bubbling for data point interactions, improving user experience.
…ved layout and functionality - Adjusted height calculations in useChartDimensions to set the main chart height to 700. - Modified LineConfidenceChart to use mainInnerHeight for overview inner height, enhancing layout consistency. - Updated ChartTooltip positioning to improve visibility by adjusting the tooltip's vertical offset. - Enhanced useChartBrush to include a filter for zoom events, ensuring better user interaction. - Refactored Chart component to improve date formatting in xFormatter and xFormatterOverview for consistency.
…components - Removed 'second' option from aggregation interval selection in Controls component. - Updated AggregationInterval type to exclude 'second' across relevant files. - Adjusted default aggregation interval to 'minute' when data is available, enhancing user experience and consistency in data handling.
…ce components - Introduced a sample size dropdown in the Controls component, allowing users to select the number of data points for visualization. - Enhanced MainChart to display a loading indicator based on both loading states and sample size loading, improving user feedback during data processing. - Updated LineConfidenceContext to manage sample size state and loading status, ensuring consistent data handling across components.
… layout - Modified text positioning in MainChart for improved alignment with chart dimensions. - Updated MeasurementsSummary to change grid layout from three columns to two on larger screens, enhancing visual consistency. - Renamed button text from "View Line Confidence" to "View Time Series" for clarity in navigation.
…visualization - Updated ChartTooltip to adjust positioning based on window dimensions, ensuring better visibility. - Added GeometryMap component to display geographical data within the tooltip. - Modified MeasurementsSummary by removing unused icon import, streamlining the component.
✅ Deploy Preview for dso-tacc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces significant improvements to the Line Confidence Chart's interaction model, replacing the brush-based navigation with a more intuitive zoom-based approach. The changes enhance user experience by providing smoother zooming capabilities and better control over the visualization.
Key Changes
1. Zoom Behavior Enhancement
2. UI/UX Improvements
3. Code Structure Improvements
4. Performance Optimizations
Technical Details
useChartBrushhook (renamed but now handles zoom behavior)Testing
Please test the following scenarios:
Screenshots
[Add relevant screenshots showing the new zoom behavior and UI improvements]
Related Issues
[Link to any related issues or tickets]