Add delete sensor/{sensor id} #118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The delete campaign route function was incorrectly named 'delete_sensor' instead of 'delete_campaign'. This fix corrects the function name to match its actual purpose. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
…-For-Disaster-Analytics/upstream-docker into add-delete-sensor/{sensor_id}
Remove redundant | None from Optional[str] | None type annotation. Optional[str] already includes None, so | None is unnecessary and causes a syntax error. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Replace all instances of modern union syntax (Type | None and type1 | type2) with Python 3.9 compatible typing imports (Optional[Type] and Union[type1, type2]). Fixed files: - app/services/station_service.py: Replace Type | None and list[str | None] - app/db/repositories/station_repository.py: Replace Station | None - app/db/repositories/measurement_repository.py: Replace various union syntax - app/db/repositories/sensor_repository.py: Replace Sensor | None and list types - app/db/repositories/campaign_repository.py: Replace Campaign | None - app/services/measurement_service.py: Replace MeasurementCreateResponse | None - app/services/export_service.py: Replace datetime | None - app/api/v1/schemas/station.py: Replace str | None, bool | None, datetime | None - app/api/v1/routes/campaigns/campaign_stations.py: Replace datetime | None - app/api/v1/routes/campaigns/root.py: Replace str | None, datetime | None, list[str] | None All modules now import successfully in Python 3.9. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Replace deprecated 'example' parameter with 'examples' in Query annotations to resolve deprecation warnings in FastAPI. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Replace modern union syntax (Type | None) with Python 3.9 compatible syntax (Optional[Type]) in test files to resolve 17 test errors. Changes: - tests/api/test_campaign_station_sensors.py: Updated union syntax in lines 121-126 - tests/test_campaign_station_sensor_measurement_routes.py: Updated union syntax in lines 83, 93 - tests/test_measurement_service.py: Updated union syntax in function parameter - Added necessary Optional import to all files - Replaced dict[str, str] with Dict[str, str] - Replaced list[Type] with List[Type] 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Change incorrect import from 'pandantic.basemodel.PandanticBaseModel' to correct 'pandantic.BaseModel' to resolve CI test failures. The pandantic library exports BaseModel from its __init__.py, not PandanticBaseModel from basemodel.py. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems i had some issues with the typing. Can you confirm this works before we merge?