Skip to content

fix: mypy #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mosoriob wants to merge 1 commit into from
Closed

fix: mypy #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/api/v1/schemas/campaign.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class ListCampaignsResponseItem(BaseModel):
end_date: datetime | None = None
allocation: str | None = None
summary: SummaryListCampaigns
geometry: dict = Field(default_factory=dict, nullable=True)
geometry: dict = Field(default_factory=dict, nullable=True) # type: ignore[call-overload,type-arg]

class ListCampaignsResponsePagination(BaseModel):
items: list[ListCampaignsResponseItem]
Expand All @@ -65,7 +65,7 @@ class GetCampaignResponse(BaseModel):
allocation: str
location: Location | None = None
summary: SummaryGetCampaign
geometry: dict = Field(default_factory=dict, nullable=True)
geometry: dict = Field(default_factory=dict, nullable=True) # type: ignore[call-overload,type-arg]
stations: list[StationsListResponseItem] = []


Expand Down
2 changes: 1 addition & 1 deletion app/api/v1/schemas/station.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class StationItem(BaseModel):
contact_email: str | None = None
active: bool | None = None
start_date: datetime | None = None
geometry: dict = Field(default_factory=dict, nullable=True)
geometry: dict = Field(default_factory=dict, nullable=True) # type: ignore[call-overload,type-arg]

class StationItemWithSummary(StationItem):
sensor_count: int
Expand Down
2 changes: 1 addition & 1 deletion app/services/campaign_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def get_campaign_with_summary(self, campaign_id: int) -> GetCampaignResponse | N
bbox_south=campaign.bbox_south,
bbox_north=campaign.bbox_north,
),
geometry=json.loads(campaign.geometry) if campaign.geometry else {},
geometry=json.loads(campaign.geometry) if campaign.geometry else {}, # type: ignore[arg-type]
stations=stations,
summary=SummaryGetCampaign(
station_count=self.campaign_repository.count_stations(campaign_id),
Expand Down
2 changes: 1 addition & 1 deletion app/services/measurement_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def list_measurements(self, sensor_id: int, start_date: datetime | None, end_dat
variabletype=row[0].variabletype,
variablename=row[0].variablename,
sensorid=row[0].sensorid,
geometry=json.loads(row[1]) if row[1] else {}
geometry=json.loads(row[1])
))
else:
print(f"Measurement {row[0].measurementid} has no geometry {row[1]}")
Expand Down