feat: refactor RoleRef to use structured type instead of string array#61
Draft
husenkuresh1 wants to merge 20 commits intomasterfrom
Draft
feat: refactor RoleRef to use structured type instead of string array#61husenkuresh1 wants to merge 20 commits intomasterfrom
husenkuresh1 wants to merge 20 commits intomasterfrom
Conversation
…g and enhance error logging
…roxy into feat/enhance-rbac
Add test cases for authorizer and permission trie
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Changes proposed
roleRef []stringtoroleRefs []v1.RoleRefin CommonBindingSpecThe
roleReffield in CommonBindingSpec has been replaced withroleRefswhich now accepts an array of RoleRef objects with APIGroup, Kind, and Name fields instead of simple string references. This affects all CRD types that use CommonBindingSpec including CAPIRoleBinding and CAPIClusterRoleBinding.Check List (Check all the applicable boxes)
Screenshots
Note to reviewers