Skip to content

feat: refactor RoleRef to use structured type instead of string array#61

Draft
husenkuresh1 wants to merge 20 commits intomasterfrom
feat/change-roleref-type
Draft

feat: refactor RoleRef to use structured type instead of string array#61
husenkuresh1 wants to merge 20 commits intomasterfrom
feat/change-roleref-type

Conversation

@husenkuresh1
Copy link
Copy Markdown

Fixes Issue

Changes proposed

  • Changed roleRef []string to roleRefs []v1.RoleRef in CommonBindingSpec
  • Updated processor logic to handle structured RoleRef objects
  • Modified all test cases and e2e tests to use new RoleRef format
  • Removed deprecated gomodules.xyz/jsonpatch/v2 dependency
  • Updated deep copy generation for new field type

⚠️ BREAKING CHANGE:

The roleRef field in CommonBindingSpec has been replaced with roleRefs which now accepts an array of RoleRef objects with APIGroup, Kind, and Name fields instead of simple string references. This affects all CRD types that use CommonBindingSpec including CAPIRoleBinding and CAPIClusterRoleBinding.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant