Fix/initial-client-list-loading#59
Open
Kshitiz1403 wants to merge 3 commits intoImprowised:masterfrom
Open
Conversation
- Replace asyncData with fetch hook in index page - Add loading state with b-overlay in List component - Add error handling for failed client list fetches - Move client list fetch to created lifecycle hook This fixes the issue where clients were only visible after creating a new client.
Author
|
@SagarVishal Can you please check this. |
This reverts commit e98197a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
This fixes the issue where clients were only visible after creating a new client.
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers