Conversation
|
I haven't actually checked it out and compiled it but it looks good to me. |
| @@ -1,366 +0,0 @@ | |||
| /// ## Changelog | |||
There was a problem hiding this comment.
I thought we would only remove it from being included to the amalgamation, but still keep the src/CHANGELOG checked into the repo (maybe with note that "changelog has been discontinued") so people can easily reason about it. This file entirely disappearing could cause some confusion (?)
There was a problem hiding this comment.
Naw, remove it all. Once we get steady releases going, accurate changelogs will be found here:
https://github.com/Immediate-Mode-UI/Nuklear/releases
There was a problem hiding this comment.
Can we archive it on a wiki page at least?
I feel a bit uneasy the file updated for past 10 years just disappears
There was a problem hiding this comment.
That's a good point. I'll leave the changelog file there with a link to archives and new one.
There was a problem hiding this comment.
Thanks!
I don't mind the content of this file disappearing. I just want the file itself to stay in same place, so people can find anything meaningful when searching for it.
If you wipe everything and only leave a message like so:
The changelog was discontinued and archived.
Please see: [link to the wiki page with short explanation and archived version]
^ I think this should be enough to avoid confusion.
Perhaps, the best would be to keep this note included into amalgamation, since I only imagine people using the amalgamation to ever care about such things, but I won't pressure about this one.
There was a problem hiding this comment.
Feel free to resolve. All my points were added.
| /// - [y]: Minor version with non-breaking API and library changes | ||
| /// - [z]: Patch version with no direct changes to the API | ||
| /// The CHANGELOG can be found for each release in: | ||
| /// https://github.com/Immediate-Mode-UI/Nuklear/releases |
There was a problem hiding this comment.
This site is empty right now. Are you planning to tag a release any time soon? I don't think it's a big deal though, even if it stays empty for several weeks. Just asking what's the plan here.
There was a problem hiding this comment.
Correct, it won't have anything until we start making those releases.
| @@ -30781,369 +30781,11 @@ nk_tooltipfv(struct nk_context *ctx, const char *fmt, va_list args) | |||
|
|
|||
| /// ## Changelog | |||
| /// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~none | |||
There was a problem hiding this comment.
(same as above)
| /// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~none | |
| /// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
Co-authored-by: sleeptightAnsiC <91839286+sleeptightAnsiC@users.noreply.github.com>
3 participants
Fixes #908