Refactor/ddd architecture and tooling#71
Open
IlyaChichkov wants to merge 3 commits intofeat/add-screenshot-capturefrom
Open
Refactor/ddd architecture and tooling#71IlyaChichkov wants to merge 3 commits intofeat/add-screenshot-capturefrom
IlyaChichkov wants to merge 3 commits intofeat/add-screenshot-capturefrom
Conversation
- Fixed corrupted RimApi.sln file to restore C# Language Server functionality. - Added workspace-level `.vscode/settings.json` and `tasks.json` for standardized build pipelines. - Implemented `.editorconfig` to establish and enforce C# coding standards. - Configured VS Code to automatically organize imports on save.
- Restructured controllers and services into Domain-Driven Design (DDD) vertical slices. - Split flat, monolithic helper classes into focused domain services with dedicated interfaces. - Added a new REST endpoint and corresponding DTO models to extract active game alerts and notifications. - Wired alerts data retrieval through the newly structured Client/UI domain service.
Contributor
|
Awesome! I do as much as I can when using Claude to make sure we adhere to your vision. This will be extremely helpful in keeping us all focused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: DDD Architecture Migration & Workspace Standardization
Description
This PR fundamentally improves the maintainability of the codebase by executing a massive architectural refactor and standardizing the developer environment.
It transitions the project from a flat, monolithic structure into a Domain-Driven Design (DDD) architecture while establishing strict tooling and linting rules to ensure code quality moving forward.
Key Changes
Architecture & Refactoring:
Client,Colony,Pawns,System,World).GamePlayHelper) into focused domain services and extracted dedicated interfaces (e.g.,IGamePlayService) to allow for proper Dependency Injection and unit testing.usingdirectives across the entire codebase.Developer Experience (Tooling):
RimApi.slnfile to fully restore C# Language Server (OmniSharp/Roslyn) functionality..vscode/settings.jsonandtasks.jsonto standardize build and deployment pipelines..editorconfigfile to enforce C# formatting standards and configured VS Code to automatically organize imports on save.Impact
These changes ensure that new developers can instantly spin up the project with working IntelliSense, automated formatting, and a predictable, domain-focused folder structure.