Skip to content

feat(drp): update & refactor with new features#6189

Merged
ChronosSF merged 2 commits intovnextfrom
bpachilova/drp-topic-updates-6187
Sep 2, 2025
Merged

feat(drp): update & refactor with new features#6189
ChronosSF merged 2 commits intovnextfrom
bpachilova/drp-topic-updates-6187

Conversation

@ddaribo
Copy link
Copy Markdown
Contributor

@ddaribo ddaribo commented Aug 26, 2025

Closes #6187

This related PR in igniteui-angular-samples modifies the "Custom actions" demo to show the predefined ranges.

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in topic content has a valuable update, it's new or considered as preview\ beta
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check broken links (use browser add-on)
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo


  • do not resolve requested changes (leave that to the reviewer)
  • add pending-localization label when the review of the PR is done
  • add a member from the localization team to translate it

@ddaribo ddaribo requested a review from kacheshmarova August 26, 2025 14:48
@kacheshmarova kacheshmarova changed the base branch from master to vnext September 1, 2025 07:07
@ddaribo ddaribo changed the base branch from vnext to master September 1, 2025 07:14
Copy link
Copy Markdown
Member

@ChronosSF ChronosSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should never pr against master only. Samples/Docs CI/CD is setup so that if you make changes for the next version (such as these) you pr them to vnext only. If you are fixing bugs that should come out asap, you pr them to vnext and master.

If you can't rebase this to vnext, just open a new one with cherrypicked commits to vnext and close this one.

@ddaribo ddaribo force-pushed the bpachilova/drp-topic-updates-6187 branch from fad0fb3 to efd5692 Compare September 2, 2025 07:20
@ddaribo ddaribo changed the base branch from master to vnext September 2, 2025 07:20
@ChronosSF ChronosSF merged commit 4759e56 into vnext Sep 2, 2025
5 checks passed
@ChronosSF ChronosSF deleted the bpachilova/drp-topic-updates-6187 branch September 2, 2025 07:53
randriova added a commit that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Date Range Picker topic with new features [WC alignment]

4 participants