fix(search): restore dialog interactions after Astro page navigation#63
Open
dobromirts wants to merge 1 commit into
Open
fix(search): restore dialog interactions after Astro page navigation#63dobromirts wants to merge 1 commit into
dobromirts wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes IgniteUI/igniteui-documentation#223
After Astro View Transitions, the DOM is replaced on each navigation. Any event listeners attached directly to dialog elements (igc-input, clear button, close button) are lost because those elements no longer exist. The _w.__searchListeners guard prevented re-attachment, so typing in the search input had no effect after navigating to a new page.
This PR converts all dialog level listeners (igcInput, clear, close, shell link click) from direct element attachment to document level event delegation using closest() checks. Since document persists across navigations, the listeners remain active regardless of DOM replacements, making search fully functional after any page transition.