Skip to content

Conversation

@vernans
Copy link
Contributor

@vernans vernans commented Oct 24, 2024

This pull request is supposed to fix #159, if there's anything I can do please contact me. I'll fill out the contributors agreement now.

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.42%. Comparing base (69fed0a) to head (65d16fb).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   76.24%   76.42%   +0.17%     
==========================================
  Files          44       44              
  Lines        4484     4484              
  Branches      984      839     -145     
==========================================
+ Hits         3419     3427       +8     
  Misses        777      777              
+ Partials      288      280       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jschlyter
jschlyter previously approved these changes Oct 24, 2024
@jschlyter jschlyter requested a review from rohe October 24, 2024 09:51
@vernans
Copy link
Contributor Author

vernans commented Oct 24, 2024

I had to delete the agreement information from the parameters, otherwise the changed line wouldn't have been tested. I ran the test against the old and the new implementation, it tests the right thing now.

@jschlyter jschlyter self-requested a review October 24, 2024 11:27
@jschlyter jschlyter merged commit 978df14 into IdentityPython:main Nov 16, 2024
8 checks passed
@sallner
Copy link

sallner commented Nov 27, 2024

Thanks for merging this and cutting a release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong type in JWE_EC.dec_setup

3 participants