Draft
Conversation
cf14f74 to
91b77ee
Compare
93f9582 to
c1351b0
Compare
e44e96d to
ba3efcc
Compare
5d8e9b2 to
a8d4219
Compare
Contributor
Author
|
Note to myself:
|
693c554 to
86196fa
Compare
86196fa to
2c04d81
Compare
Remove icinga dependency
…riables Remove/decouple icinga(behavior) based code Remove/decouple icinga-based code
it somehow became irrelevant, but must have been important before. But now that we don't want any icingaweb-specific code here, it has to be removed anyway. it become somehow inrelevent, must be relevant before. But now as we dont want any icingaweb specific code here it must be removed anyway.
Dont explicitely check for .page-seperator to skip element, skip until an selectable one found or list ends
seems unnecessory, deactivating and activating the same element again and again
…ull if list ends Make idetifiers const
use this.list instead of getting list from dom
Remove unused code
This way we avoid adding it to every module that should support actionList functionality.
2c04d81 to
4d29138
Compare
Contributor
Author
|
Discussed with @nilmerg offline. Proposed improvements:
|
If the list already contains active items, keypress should navigate to this this.
Remove superfluous sufix `List` from properties
Optimize code
… is passed as item
For example, the elements of icingadb/hostgroup are `display:contents`, which leads to scrollIntoView() having no effect.
b60b125 to
7d91ee2
Compare
… register behavior
7d91ee2 to
b46a751
Compare
- ActionListBehavior: Use setters to init ActionList
… or `all-deselected` - Otherwise when `(detail)column-closed` or `all-deselected`, while on the last/first list item and then pressing up/down key again, the item activation is ignored.
- It is not necessary to explicitly search for #main or body, the current change should suffice.
- The `this.#list.checkVisibility()` condition is sufficient
b46a751 to
4a81af3
Compare
- Same as calling bind directly after construction
- This also worked well before, but it seems to be incomplete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires:
Icingatoipl/webbehaviors icingaweb2#5238