Skip to content

Add RegexMatchValidator#19

Merged
lippserd merged 6 commits intomainfrom
add-regex-validator
Mar 10, 2026
Merged

Add RegexMatchValidator#19
lippserd merged 6 commits intomainfrom
add-regex-validator

Conversation

@sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Dec 28, 2022

TODOs:

  • Add Tests

@cla-bot cla-bot bot added the cla/signed label Dec 28, 2022
@sukhwinder33445 sukhwinder33445 marked this pull request as draft December 28, 2022 14:58
@sukhwinder33445 sukhwinder33445 self-assigned this Dec 28, 2022
Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your validator is named RegexValidator, though it doesn't validate a regex. It validates plain text as specified by a regex.

Moreover: I shall make a validator which actually validates a regex.

Let's agree upon names which both don't conflict and are obvious to lib users! Any suggestions?

@sukhwinder33445
Copy link
Contributor Author

What about PatternMatchValidator ? For example, InArrayValidator checks whether a value is in an array; this class would check whether a value matches a pattern.

@lippserd
Copy link
Member

What about PatternMatchValidator ? For example, InArrayValidator checks whether a value is in an array; this class would check whether a value matches a pattern.

I like that. What about RegexSyntaxValidator and RegexMatchValidator? That makes it perfectly clear in my opinion.

Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename to RegexMatchValidator.

@sukhwinder33445 sukhwinder33445 changed the title Add RegexValidator Add RegexMatchValidator Jan 14, 2026
@sukhwinder33445 sukhwinder33445 force-pushed the add-regex-validator branch 2 times, most recently from 9545d87 to d20f7fb Compare January 14, 2026 10:34
@lippserd
Copy link
Member

Since this PR has been in the draft stage for quite some time, I wonder if we really have a use case for this validator. If so, I'd suggest we finish it. Otherwise, we can just close the PR.

@sukhwinder33445
Copy link
Contributor Author

Yes, there are currently no use cases.

@sukhwinder33445 sukhwinder33445 deleted the add-regex-validator branch January 14, 2026 15:01
@Al2Klimov
Copy link
Member

Use case

In https://git.icinga.com/aklimov/pocssooidc/-/merge_requests/1, I'd like to ensure that URLs start only with ~^https?://~.

@Al2Klimov Al2Klimov restored the add-regex-validator branch February 5, 2026 09:11
@Al2Klimov Al2Klimov reopened this Feb 5, 2026
@cla-bot

This comment was marked as resolved.

@cla-bot cla-bot bot removed the cla/signed label Feb 11, 2026
@Al2Klimov Al2Klimov assigned bobapple and unassigned Al2Klimov Feb 11, 2026
@Al2Klimov Al2Klimov marked this pull request as ready for review February 11, 2026 14:06
@bobapple
Copy link
Member

@cla-bot check

@cla-bot

This comment was marked as resolved.

@Al2Klimov Al2Klimov removed their assignment Feb 16, 2026
@Al2Klimov Al2Klimov requested a review from lippserd February 16, 2026 14:21
@Al2Klimov Al2Klimov marked this pull request as draft March 4, 2026 09:18
@Al2Klimov Al2Klimov self-assigned this Mar 4, 2026
@Al2Klimov Al2Klimov force-pushed the add-regex-validator branch from f99db3a to 66cd1c0 Compare March 4, 2026 09:27
@Al2Klimov Al2Klimov marked this pull request as ready for review March 4, 2026 09:28
@Al2Klimov Al2Klimov removed their assignment Mar 4, 2026
@Al2Klimov Al2Klimov requested a review from lippserd March 4, 2026 09:29
@Al2Klimov Al2Klimov marked this pull request as draft March 10, 2026 09:07
@Al2Klimov Al2Klimov self-assigned this Mar 10, 2026
@Al2Klimov Al2Klimov force-pushed the add-regex-validator branch 3 times, most recently from 28d977d to d2f614c Compare March 10, 2026 09:31
@Al2Klimov Al2Klimov marked this pull request as ready for review March 10, 2026 09:31
@Al2Klimov Al2Klimov removed their assignment Mar 10, 2026
@Al2Klimov Al2Klimov force-pushed the add-regex-validator branch from d2f614c to 77b9e27 Compare March 10, 2026 10:14
@lippserd lippserd force-pushed the add-regex-validator branch from 77b9e27 to dd7f7c3 Compare March 10, 2026 14:44
@lippserd lippserd merged commit 4c8d4bd into main Mar 10, 2026
13 checks passed
@lippserd lippserd deleted the add-regex-validator branch March 10, 2026 14:45
@lippserd lippserd added this to the v0.6.0 milestone Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants