Open
Conversation
sukhwinder33445
force-pushed
the
modernize-code-with-breaking-changes
branch
from
8e7f322 to
65116eb
Compare
BastianLedererIcinga
previously approved these changes
Mar 20, 2026
lippserd
reviewed
Mar 20, 2026
src/Connection.php
Outdated
| public function prepexec( | ||
| Delete|Insert|Select|Update|string $stmt, | ||
| string|array|null $values = null | ||
| ): PDOStatement|false { |
Contributor
Author
There was a problem hiding this comment.
I added this because PDO::prepare() could return false, but overlooked that the default adapter option (PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION) enforce PDO to throw an exception instead of returning false.
I will remove the false return type.
sukhwinder33445
force-pushed
the
modernize-code-with-breaking-changes
branch
from
65116eb to
eacf096
Compare
This change requires an adjustment in the sub-class `Icinga\Module\Reporting\RetryConnection` of the reporting module.
sukhwinder33445
force-pushed
the
modernize-code-with-breaking-changes
branch
from
eacf096 to
287e959
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds parameter types and return types to method
Connection::prepexec().This change requires an adjustment in the sub-class
Icinga\Module\Reporting\RetryConnectionof the reporting module.