Conversation
Jan-Schuppik
previously approved these changes
Dec 10, 2025
sukhwinder33445
previously approved these changes
Dec 10, 2025
Jan-Schuppik
previously approved these changes
Dec 11, 2025
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
0423869 to
9816678
Compare
BastianLedererIcinga
dismissed stale reviews from sukhwinder33445 and Jan-Schuppik
via
1dee412
BastianLedererIcinga
force-pushed
the
modernize-code
branch
3 times, most recently
from
e67cae3 to
049ef40
Compare
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
049ef40 to
0f80362
Compare
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
c3f94e3 to
97f5cd6
Compare
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
97f5cd6 to
577046f
Compare
sukhwinder33445
previously approved these changes
Mar 5, 2026
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
Looks good to me.
@lippserd, please take a look at this.
lippserd
force-pushed
the
modernize-code
branch
from
577046f to
0d0907f
Compare
Member
2 tasks
Add strict type declarations to properties, function/method signatures, where types are unambiguous and no inheritance or interface contract is affected. Bump minimum PHP requirement to 7.4, as typed properties require at least that version. Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>
lippserd
previously approved these changes
Mar 12, 2026
Member
There was a problem hiding this comment.
I have checked all consumers and confirmed that none of the changes introduce any backwards-incompatible effects for them.
There is one place in Icinga Web's Form that uses the Translator's methods internally and passes arguments from an untyped method, but this is fine because we always call with the correct type.
lippserd
force-pushed
the
modernize-code
branch
from
0d0907f to
06c6542
Compare
lippserd
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add strict type declarations to properties, function/method signatures, where
types are unambiguous and no inheritance or interface contract is affected.