Draft
Conversation
raviks789
force-pushed
the
dictionary-support
branch
9 times, most recently
from
dd916d4 to
f19501d
Compare
raviks789
force-pushed
the
dictionary-support
branch
2 times, most recently
from
2ddc75b to
3583514
Compare
raviks789
force-pushed
the
dictionary-support
branch
10 times, most recently
from
e818e3e to
3260c35
Compare
raviks789
force-pushed
the
dictionary-support
branch
8 times, most recently
from
01bbc41 to
e1fac6d
Compare
raviks789
force-pushed
the
dictionary-support
branch
4 times, most recently
from
83e5b92 to
5fcc055
Compare
raviks789
force-pushed
the
dictionary-support
branch
2 times, most recently
from
e82288c to
94e9225
Compare
raviks789
force-pushed
the
dictionary-support
branch
7 times, most recently
from
6493a77 to
0807528
Compare
raviks789
force-pushed
the
dictionary-support
branch
5 times, most recently
from
afa36bc to
57bf362
Compare
raviks789
force-pushed
the
dictionary-support
branch
from
f7cac18 to
8f85549
Compare
raviks789
force-pushed
the
dictionary-support
branch
2 times, most recently
from
4c6962e to
7aba001
Compare
Member
|
Unfortunately, I had to revert automatic form element escaping in ipl-html: Icinga/ipl-html#196 So you have to protect against invalid form element names here on your own. A viable and easy alternative might be hashing the names using md5. |
Collaborator
Author
Thanks for the info! However, the implementation has changed since then and custom variable names are no longer used as form element names. Hence, reverting those changes will not affect this PR. |
Introduce a first-class DirectorProperty concept that extends the existing
data-fields model with rich, structured variable types. Custom variables can
now be defined globally under a new "Custom Variables" section and assigned
to Icinga objects (hosts, services, commands, etc.).
Supported types: string, number, boolean, fixed-array, dynamic-array,
datalist-strict, datalist-non-strict, fixed-dictionary, and
dynamic-dictionary (one level of nesting allowed).
Key changes:
- DirectorProperty object with CRUD, inheritance, and apply-for rule support
- New form elements: Dictionary, DictionaryItem, NestedDictionary,
NestedDictionaryItem, ArrayElement, IplBoolean
- CustomvarController for managing global property definitions
- VariablesController for per-object variable assignment
- BasketSnapshotCustomVariableResolver for basket import/export of properties
- REST API: IcingaObjectHandler extended to expose and accept structured vars
- IcingaConfigHelper: renders dictionaries/arrays to valid Icinga 2 DSL
- CustomVarRenderer updated for icingadb hook display
- DB migration upgrade_192.sql: new director_property and related tables
- CLI: MigrateCommand for migrating legacy vars to properties;
HostsCommand for bulk host custom variable management
Constraints follow the pattern `<table>_<column>`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires:
Icinga/ipl-web#355
Icinga/ipl-web#301