Skip to content

icinga2: address comment loading where host reference is not found #9861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julianbrost merged 2 commits into from
Jan 7, 2025
Merged

icinga2: address comment loading where host reference is not found #9861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e92450
icinga2: address comment loading where host reference is not found
ymartin-ovh Sep 11, 2023
d9e3a9c
AUTHORS: add Yannick Martin <yannick.martin@ovhcloud.com>
Al2Klimov Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ Winfried Angele <winfried.angele@gmail.com>
Wolfgang Nieder <wnd@gmx.net>
XnS <git@xns.be>
Yannick Charton <tontonitch-pro@yahoo.fr>
Yannick Martin <yannick.martin@ovhcloud.com>
Yohan Jarosz <yohanjarosz@yahoo.fr>
Yonas Habteab <yonas.habteab@icinga.com>
Zachary McGibbon <zachary.mcgibbon@gmail.com>
Expand Down
2 changes: 1 addition & 1 deletion lib/icinga/comment.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ void Comment::OnAllConfigLoaded()

Host::Ptr host = Host::GetByName(GetHostName());

if (GetServiceName().IsEmpty())
if (GetServiceName().IsEmpty() || ! host)
m_Checkable = host;
else
m_Checkable = host->GetServiceByShortName(GetServiceName());
Copy link
Copy Markdown
Member

@Al2Klimov Al2Klimov Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

@julianbrost julianbrost Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9861 (comment):

I maintain my own build because of this.

Sounds like it should already be tested?

Expand Down