WIP: GelfWriter: Implement support for event type filters#7868
Closed
WIP: GelfWriter: Implement support for event type filters#7868
Conversation
dnsmichi
added
area/graylog
Member
|
Can anyone with more knowledge about Graylog tell if this is something that would be useful? |
Contributor
|
After talking to @xtruthx about this, we came to the conclusion that this indeed could be very helpful. Especially for those that use the Graylog Cloud which only offers volume based subscriptions. |
Al2Klimov
reviewed
Feb 1, 2023
Member
Al2Klimov
left a comment
Al2Klimov
left a comment
There was a problem hiding this comment.
The changes do what they promise. Do we want this?
Member
|
IMAO yes. #7868 (comment) |
Al2Klimov
added
needs feedback
Member
|
I'd even document it if there are no other volunteers. |
Member
|
I would rather close this PR as literally no one has asked for such a feature and so this is work for nothing. |
Member
|
See #7868 (comment). |
Member
|
Strange... Even our new ElasticsearchDatastreamWriter supports such filtering: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this in my local branch list from 2018.
TODOs: