Always call HttpUtility::SendJsonBody() with a boost::asio::yield_context#10764
Open
Always call HttpUtility::SendJsonBody() with a boost::asio::yield_context#10764
HttpUtility::SendJsonBody() with a boost::asio::yield_context#10764Conversation
…context` to respect `l_FlushThreshold` in all messages. Especially `l_FlushThreshold` may now be lowered in the future without re-evaluating all possible responses. Side effect: all HTTP responses use chunked encoding now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to respect
l_FlushThresholdin all messages.Especially
l_FlushThresholdmay now be lowered in the future without re-evaluating all possible responses.Side effect: all HTTP responses use chunked encoding now.
By the way...
boost::asio::yield_contextdeeper through the code, but you may want to look at the adjusted unit tests