Skip to content

Don't upload 32 bit MSIs to Chocolatey#10757

Merged
yhabteab merged 2 commits intomasterfrom
10754
Mar 17, 2026
Merged

Don't upload 32 bit MSIs to Chocolatey#10757
yhabteab merged 2 commits intomasterfrom
10754

Conversation

@Al2Klimov
Copy link
Member

Precisely speaking, tools/win32/build-choco.ps1 creates a PS script that downloads our MSIs from packages.icinga.com - to be uploaded to Chocolatey. This PS script now omits 32 bit MSIs.

Despite being a niche, 32-bit MSIs currently get uploaded to Chocolatey. Their antiviruses block our whole releases due to the 32-bit MSIs being fishy.

fixes #10754

Test

  1. Download and extract https://git.icinga.com/packages/special/windows-icinga2/-/jobs/832336
  2. Rename the .nupkg file to .zip, then extract it
  3. Edit tools/chocolateyInstall.ps1, correct the checksum64 value 🙈 (see curl -fsSL https://packages.icinga.com/windows/Icinga2-v2.15.0-x86_64.msi |sha256sum -)
  4. Install Chocolatey
  5. Set-ExecutionPolicy -Scope Process -ExecutionPolicy Bypass -Force
  6. Import-Module C:\ProgramData\chocolatey\helpers\chocolateyInstaller.psm1
  7. & C:\icinga2.2.15.0.327.nupkg\tools\chocolateyInstall.ps1

"icinga2 has been installed." 👍

Precisely speaking, `tools/win32/build-choco.ps1` creates a PS script that
downloads our MSIs from packages.icinga.com - to be uploaded to Chocolatey.
This PS script now omits 32 bit MSIs.

Despite being a niche, 32-bit MSIs currently get uploaded to Chocolatey.
Their antiviruses block our whole releases due to the 32-bit MSIs being fishy.
@cla-bot cla-bot bot added the cla/signed label Mar 12, 2026
@Al2Klimov Al2Klimov added backport-to-support/2.15 PRs with this label will automatically be backported to the v2.15 support branch. backport-to-support/2.14 PRs with this label will automatically be backported to the v2.14 support branch. backport-to-support/2.13 PRs with this label will automatically be backported to the v2.13 support branch. labels Mar 13, 2026
@Al2Klimov Al2Klimov modified the milestones: 2.14.9, 2.16.0 Mar 13, 2026
@Al2Klimov Al2Klimov requested a review from yhabteab March 13, 2026 11:30
@yhabteab yhabteab removed the backport-to-support/2.13 PRs with this label will automatically be backported to the v2.13 support branch. label Mar 13, 2026
@Al2Klimov Al2Klimov requested a review from yhabteab March 13, 2026 13:33
Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test any of the described steps, but I trust that you have and this works as expected. So, this is my soft approval for the changes!

@yhabteab yhabteab merged commit 50b4bc5 into master Mar 17, 2026
28 checks passed
@yhabteab yhabteab deleted the 10754 branch March 17, 2026 14:31
@backbot-ci
Copy link

backbot-ci bot commented Mar 17, 2026

Successfully created backport PR for support/2.15:

@backbot-ci
Copy link

backbot-ci bot commented Mar 17, 2026

Successfully created backport PR for support/2.14:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-support/2.14 PRs with this label will automatically be backported to the v2.14 support branch. backport-to-support/2.15 PRs with this label will automatically be backported to the v2.15 support branch. cla/signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't upload 32 bit MSIs to Chocolatey

2 participants