Add a check command for NETGEAR monitoring

[DsgnrFH]

No description provided.

[Al2Klimov]

• Make the GitHub actions green
• Add documentation to doc/10-icinga-template-library.md
• In a GitHub comment, give an example config file to throw into /etc/icinga2/conf.d of a default Icinga2 install – with a Service that uses your check command to prove latter works

[DsgnrFH]

• Make the GitHub actions green

  • Add documentation to doc/10-icinga-template-library.md

  • In a GitHub comment, give an example config file to throw into /etc/icinga2/conf.d of a default Icinga2 install – with a Service that uses your check command to prove latter works

Create the following file:
/etc/icinga2/conf.d/netgear.conf
With the following contents:
object Host "netgear-switch" {
import "generic-host"
address = "192.168.0.239"
}

object CheckCommand "netgear" {
command = [ PluginDir + "/check_netgear" ]
arguments = {
"-base-url" = "$netgear_base_url$"
"-username" = {
value = "$netgear_username$"
required = true
}
"-password" = {
value = "$netgear_password$"
required = true
}
}
}

apply Service "netgear-status" {
import "generic-service"

check_command = "netgear"
vars.netgear_base_url = "http://192.168.0.239"
vars.netgear_username = "admin"
vars.netgear_password = "password"

assign where host.name == "netgear-switch"
}

[oxzi]

@DsgnrFH: Please communicate the changes you have done to address review comments. Just add a comment in each thread to say that you have addressed it, and, if non obvious, how and where you did so.

[DsgnrFH]

Waiting for the checks to complete...

OP addressed review

[oxzi]

Before merging, please squash all your commits.

[Al2Klimov]

Actually, right to "Enable auto-merge", there's a dropdown allowing to "Squash and merge". We already did this with #9062.

OP addressed review

[DsgnrFH]

Commits squashed, ready to merge or further reviews

[Al2Klimov]

Test

object Service "netgear" {
  host_name = NodeName
  check_command = "netgear"

  vars.netgear_base_url = "http://$check_address$"
  vars.netgear_username = "admin"
  vars.netgear_password = "password"
}

works:

states: critical=1
\_  Device Info: Uptime - 0 days, 4 hrs, 9 mins, 32 secs
    \_  CPU Usage: 4.81%
    \_  RAM Usage: 32.77%
    \_  Temperature
        \_  sensor-System1: 32.0°C
        \_  sensor-MAC: 33.0°C
        \_  sensor-System2: 31.0°C
    \_  Fans
        \_  FAN-1: 5118 RPM

E.g vars.netgear_fan_critical = 9000 also works:

states: warning=1
\_  Device Info: Uptime - 0 days, 4 hrs, 12 mins, 20 secs
    \_  CPU Usage: 5.39%
    \_  RAM Usage: 32.77%
    \_  Temperature
        \_  sensor-System1: 32.0°C
        \_  sensor-MAC: 33.0°C
        \_  sensor-System2: 31.0°C
    \_  Fans
        \_  FAN-1: 5118 RPM

[Al2Klimov]

Suggested change

	netgear\_base\_url | **Required.** Base URL of the NETGEAR API (example: "http://$check_address$").
	netgear\_base\_url | **Required.** Base URL of the NETGEAR API (example: `http://$check_address$`).

[oxzi]

Suggested change

	set_if = "$netgear_noperfdata$"
	set_if = "$netgear_hide_perfdata$"

[oxzi]

This is a bit weird, and not on your part. It seems like GitHub's Markdown render now cannot handle a | within a monospace code. Consider the following rendered output:

I was able to reproduce this in this very text box.

| a | b
----|------
| a | `a|b`

Results in:

a	b
a	`a

---

Thus, maybe change this line as follows:

Suggested change

	netgear\_mode | **Optional.** Output modes to enable `{basic|ports|poe|all}` (repeatable). Default: `basic`.
	netgear\_mode | **Optional.** Output modes to enable. Array of `basic`, `ports`, `poe`, `all`. Default: `[ "basic" ]`.

[oxzi]

Suggested change

	netgear\_ports | **Optional.** Ports to check (repeatable). Default: `1,2,3,4,5,6,7,8`.
	netgear\_ports | **Optional.** Ports to check as an array. Default: `[ 1,2,3,4,5,6,7,8 ]`.