DependencyGraph: use ConfigObject*, not Object*#10264
Merged
Conversation
2 tasks
5547c12 to
af064c8
Compare
Al2Klimov
commented
Dec 12, 2024
Member
Author
|
yhabteab
requested changes
Dec 16, 2024
Member
yhabteab
left a comment
There was a problem hiding this comment.
If this PR is just about replacing Object* with ConfigObject*, why did you make so many unrelated changes? For example, why did you replace std::map with std::unordered_map, knowing that this will be changed with #10000 anyway? If you want me to review this, then please drop all the unrelated changes that are not related to what the PR title advertises.
af064c8 to
3022d0c
Compare
Member
Author
|
I've removed the top commit. (af064c8) |
yhabteab
reviewed
Dec 16, 2024
6db2662 to
78c68b4
Compare
yhabteab
reviewed
Dec 17, 2024
78c68b4 to
5e81b4d
Compare
yhabteab
reviewed
Dec 17, 2024
5e81b4d to
6db2662
Compare
This saves dynamic_cast<ConfigObject*> + if() on every item of GetChildren().
6db2662 to
3a09cf7
Compare
yhabteab
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves dynamic_cast<ConfigObject*> + if() on every item of GetChildren().
TODO