Allow benchmarking of CpuBoundWork#CpuBoundWork() via additional out-param#10167
Allow benchmarking of CpuBoundWork#CpuBoundWork() via additional out-param#10167
Conversation
Al2Klimov
added
the
core/quality
yhabteab
left a comment
yhabteab
left a comment
There was a problem hiding this comment.
Please add an appropriate description for the newly introduced constructors, describing why and how they should be used. How is someone supposed to figure out that he has to use the overloaded constructor with the took duration argument set to obtain the elapsed time on acquiring the semaphore?
Al2Klimov
force-pushed
the
CpuBoundWork-benchmarking
branch
from
350ce94 to
687fbd2
Compare
yhabteab
left a comment
yhabteab
left a comment
There was a problem hiding this comment.
Did you read this comment #10141 (comment)?
|
I am not sure how to interpret your reaction with 👍🏼 to the above comment. Does that mean you read it and still want to have this PR merged? To clarify, I am against this PR as we don't need that level of precision, and PR #10141 is sufficient for our use case. |
|
Name the last time I've used "it's sufficient" as argument and colleagues agreed with me. (I don't remember.) Not to mention the ratio agreed/ not agreed. But, OK, I don't insist on this specific change. |
Al2Klimov
force-pushed
the
CpuBoundWork-benchmarking
branch
from
687fbd2 to
76503f6
Compare
2 participants
No description provided.