Type#GetLoadDependencies(): VERIFY() that no nullptr is returned

[Al2Klimov]

• CC ConfigItem::CommitNewItems(): pre-sort types by their load dependencies once #10003 (comment)

[yhabteab]

That's much better, but why are you using two different loops for declaring and verifying them? Can't you just combine them like that?

Suggested change

	for (auto& dep : klass.LoadDependencies)
	m_Impl << "\t\tauto type" << dep << " (GetByName(\"" << dep << "\").get());" << std::endl;
	for (auto& dep : klass.LoadDependencies) {
	m_Impl << "\t\tauto type" << dep << " (GetByName(\"" << dep << "\").get());" << std::endl;
	m_Impl << "\t\tVERIFY(type" << dep << ");" << std::endl;
	}
	m_Impl << std::endl << "\t\treturn std::unordered_set<Type*>{";

[Al2Klimov]

But I prefer this:

const std::unordered_set<Type*>& TypeImpl<Service>::GetLoadDependencies() const
{
	static const auto deps ([] {
		auto typeApiListener (GetByName("ApiListener").get());
		auto typeEndpoint (GetByName("Endpoint").get());
		auto typeHost (GetByName("Host").get());
		auto typeZone (GetByName("Zone").get());

		VERIFY(typeApiListener);
		VERIFY(typeEndpoint);
		VERIFY(typeHost);
		VERIFY(typeZone);

		return std::unordered_set{ typeApiListener, typeEndpoint, typeHost, typeZone, };
	}());

	return deps;
}

[yhabteab]

Ah, let's do this!