Ensure forward compatibility with ipl-orm by aligning return types#171
Merged
Ensure forward compatibility with ipl-orm by aligning return types#171
ipl-orm by aligning return types#171Conversation
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
0d82e35 to
0449ace
Compare
sukhwinder33445
approved these changes
Mar 6, 2026
BastianLedererIcinga
changed the title
For forward compatibility with ipl-orm the return type should be compatible with `?Rule`, so it is changed from `void` to `null`
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
0449ace to
72c4cfc
Compare
17 tasks
lippserd
changed the title
ipl-orm by aligning return types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align return types in
ipl-orm-derived methods forupcoming strict typing compatibility.
refs Icinga/ipl-orm#158