Add Phase 2: Domain data models and types#3
Merged
Conversation
Implement all data model classes that define the contracts between
components (trainer, thinker, trader, hub):
- models/types.py: Type aliases (Timeframe, CoinSymbol, SignalLevel, PriceLevel)
- models/candle.py: Immutable Candle dataclass with derived properties
(body_pct, range_pct, shadows, direction)
- models/signal.py: Immutable Signal dataclass with entry/neutral helpers
and per-timeframe boundary validation
- models/position.py: Mutable Position dataclass with avg_price, pnl_pct,
market_value, and DCA tracking
- models/trade.py: Immutable Trade dataclass with to_dict/from_dict for
JSON-lines serialisation (supports both new and legacy schemas)
- models/memory.py: Mutable PatternMemory dataclass with to_memory_text/
from_memory_text for the custom on-disk format (~ and {} delimiters)
138 new unit tests covering construction, properties, validation, and
serialisation round-trips. All 359 tests pass, ruff/mypy/format clean.
https://claude.ai/code/session_01YCzrLj8szZHwkZvrghNf5V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement all data model classes that define the contracts between
components (trainer, thinker, trader, hub):
(body_pct, range_pct, shadows, direction)
and per-timeframe boundary validation
market_value, and DCA tracking
JSON-lines serialisation (supports both new and legacy schemas)
from_memory_text for the custom on-disk format (~ and {} delimiters)
138 new unit tests covering construction, properties, validation, and
serialisation round-trips. All 359 tests pass, ruff/mypy/format clean.
https://claude.ai/code/session_01YCzrLj8szZHwkZvrghNf5V