Skip to content

Conversation

@hmihaella
Copy link

No description provided.

@hmihaella hmihaella changed the title Add files via upload Mihaela Halip - 1st Projecy Jul 25, 2022
@hmihaella hmihaella changed the title Mihaela Halip - 1st Projecy Mihaela Halip - 1st Project Jul 25, 2022
padding: 0.5rem 1rem;
inset-block-start: 50%;
inset-inline-start: 50%;
transform: translate(-50%, -50%);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poți să pui câteva din proprietățile CSS într-un fișier separat, ca să nu le repeți mereu.


@media (min-width: 186px) {
.container {
font-size: 0.75rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dimensiunea fontului era 1rem înaintea media query-ului, ceea ce oricum era prea mare.

Mi se pare ciudat că scade la primul nivel de responsive.

}

.container::-webkit-scrollbar-track {
-webkit-box-shadow: inset 0 0 0.4rem rgba(0, 0, 0, 0.3);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cred că puteai folosi box-shadow aici.

<h2>CONTACT US</h2>
<p type="Name:"><input placeholder="Write your name here"></input></p>
<p type="Email:"><input placeholder="Let us know how to contact you back"></input></p>
<p type="Message:"><input placeholder="What would you like to tell us"></input></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

În loc de <p>, ai putea folosi <label>. E mai corect semantic.

<body>
<form class="form">
<h2>CONTACT US</h2>
<p type="Name:"><input placeholder="Write your name here"></input></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paragraful nu are atribut type. Dacă vrem să folosim atribute care nu există, trebuie să folosim prefixul data-.

<form class="form">
<h2>CONTACT US</h2>
<p type="Name:"><input placeholder="Write your name here"></input></p>
<p type="Email:"><input placeholder="Let us know how to contact you back"></input></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elementul <input> nu are tag de închidere. Se auto-închide.

<input placeholder="Let us know how to contact you back" />

background-size: cover;
}
.container {
font-family: "Dancing Script", cursive;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acest font nu pare declarat nicăieri.

<meta http-equiv="X-UA-Compatible" content="ie=edge" />
<link
rel="stylesheet"
href="https://use.fontawesome.com/releases/v5.6.3/css/all.css"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nu îmi dau seama: Unde e folosit Font Awesome?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants