-
Notifications
You must be signed in to change notification settings - Fork 9
Mihaela Halip - 1st Project #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| padding: 0.5rem 1rem; | ||
| inset-block-start: 50%; | ||
| inset-inline-start: 50%; | ||
| transform: translate(-50%, -50%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poți să pui câteva din proprietățile CSS într-un fișier separat, ca să nu le repeți mereu.
|
|
||
| @media (min-width: 186px) { | ||
| .container { | ||
| font-size: 0.75rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dimensiunea fontului era 1rem înaintea media query-ului, ceea ce oricum era prea mare.
Mi se pare ciudat că scade la primul nivel de responsive.
| } | ||
|
|
||
| .container::-webkit-scrollbar-track { | ||
| -webkit-box-shadow: inset 0 0 0.4rem rgba(0, 0, 0, 0.3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cred că puteai folosi box-shadow aici.
| <h2>CONTACT US</h2> | ||
| <p type="Name:"><input placeholder="Write your name here"></input></p> | ||
| <p type="Email:"><input placeholder="Let us know how to contact you back"></input></p> | ||
| <p type="Message:"><input placeholder="What would you like to tell us"></input></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
În loc de <p>, ai putea folosi <label>. E mai corect semantic.
| <body> | ||
| <form class="form"> | ||
| <h2>CONTACT US</h2> | ||
| <p type="Name:"><input placeholder="Write your name here"></input></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paragraful nu are atribut type. Dacă vrem să folosim atribute care nu există, trebuie să folosim prefixul data-.
| <form class="form"> | ||
| <h2>CONTACT US</h2> | ||
| <p type="Name:"><input placeholder="Write your name here"></input></p> | ||
| <p type="Email:"><input placeholder="Let us know how to contact you back"></input></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elementul <input> nu are tag de închidere. Se auto-închide.
<input placeholder="Let us know how to contact you back" />| background-size: cover; | ||
| } | ||
| .container { | ||
| font-family: "Dancing Script", cursive; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acest font nu pare declarat nicăieri.
| <meta http-equiv="X-UA-Compatible" content="ie=edge" /> | ||
| <link | ||
| rel="stylesheet" | ||
| href="https://use.fontawesome.com/releases/v5.6.3/css/all.css" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nu îmi dau seama: Unde e folosit Font Awesome?
No description provided.