Fix for tf.keras: Cast input_dims to int.#4
Open
fa9r wants to merge 1 commit intoIShengFang:masterfrom
Open
Conversation
…y int in Keras, this should not affect Keras functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, your code only works for regular Keras, but not for tf.keras, because input_shape is a tensor in Tensorflow. By simply casting all input_dim to int, your code should work for both Keras (where input_dim is already int) and tf.keras.
This is useful, because some TF functionalities (like efficient data loading) only work with tf.keras, and tf.keras and keras layers cannot be combined.
To see how imports have to be changed for tf.keras, see https://github.com/fa9r/SpectralNormalizationTensorflowKeras