Ksenija lizko by RinOttawa · Pull Request #51 · ISUCT/Tprogramming_42_2019

RinOttawa · 2019-11-02T18:43:20Z

jskonst · 2019-11-11T05:55:37Z

Build Failed :( Надо проверить почему сборка не проходит - проблема версия .net - надо тогда или до 2.1 снизить или в Actions - файле сборки поправить

jskonst · 2019-11-11T05:56:02Z

+    - name: Setup .NET Core
+      uses: actions/setup-dotnet@v1
+      with:
+        dotnet-version: 2.1.802


Вот тут можно на 3-. попробовать поменять

jskonst · 2019-11-11T05:57:27Z

+        [Fact]
+        public void Test1()
+        {
+


Тестов бы добавить

jskonst · 2019-11-11T05:58:28Z

+{
+    public class Program
+    {
+        public static void Сalculation(double x_h, double x_k, double dx)


переименуйте x_n -> xN (остальные переменные тоже проверьте) - в c# не принят snake_case (как в питоне), а принят camelCase

jskonst · 2019-11-25T06:10:08Z

@RinOttawa

Не работают тесты
Не поправлены review points
Build упал

jskonst · 2019-11-25T06:10:22Z

🔧

jskonst · 2019-12-21T10:31:28Z

+            double[] b = { 0.1, 0.35, 0.4, 0.55, 0.6 };
+            for (int i = 0; i < 5; i++)
+            {
+                y2 = Math.Pow(Math.Pow(Math.Asin(b[i]), 2) + Math.Pow(Math.Cos(b[i]), 4), 3);


Само вычисление следует вынести в отдельный метод

jskonst · 2019-12-21T10:31:42Z

+        public static void Сalculation2()
+        {
+            double y2;
+            double[] b = { 0.1, 0.35, 0.4, 0.55, 0.6 };


Эти параметры должны передаваться снаружи

jskonst · 2019-12-21T10:32:04Z

+            for (double x = xH; x <= xK; x = x + dx)
+            {
+                y = Math.Pow(Math.Pow(Math.Asin(x), 2) + Math.Pow(Math.Cos(x), 4), 3);
+                Console.WriteLine(y + " ");


Используйте форматированные строки

jskonst · 2019-12-21T10:32:34Z

+        public static void Сalculation2()
+        {
+            double y2;
+            double[] b = { 0.1, 0.35, 0.4, 0.55, 0.6 };


Используйте списки вместо массивов

RinOttawa · 2020-10-14T01:01:18Z

@jskonst добавила юнит тест к задаче на вычисления

jskonst · 2020-10-19T15:34:04Z

+        {
+            int i = 0;
+            List<double> output = new List<double>();
+            for (double x = xH; x <= xK; x = x + dx)


jskonst · 2020-10-19T15:34:30Z

+            for (double x = xH; x <= xK; x = x + dx)
+            {
+                output.Add(Mathhh(x));
+                Console.WriteLine(Mathhh(x));


this function should not write into console

jskonst · 2020-10-19T15:34:44Z

+            {
+                output.Add(Mathhh(x));
+                Console.WriteLine(Mathhh(x));
+                i++;


jskonst · 2020-10-19T15:34:59Z

+            foreach (double i in b)
+            {
+               output.Add(Mathhh(i));
+               Console.WriteLine(Mathhh(i));


same here for output

jskonst · 2020-10-19T15:36:17Z

+            List<double> input = new List<double>() { 0.1, 0.35, 0.4, 0.55, 0.6 };
+            var res = Program.Сalculation2(input);
+            List<double> result = new List<double>() { 0.970885488727385, 0.744968715506544, 0.702712806929317, 0.65257962383342, 0.677063603240845 };
+            Assert.Equal(res, result);


equale for double should have accuracy (3 digits after .)

jskonst and others added 11 commits September 16, 2019 09:29

Sample .net app

bb95848

Initial app with tests

cf10946

Added workspace for vsCode

591e070

FIxed stylecop file

435b5bc

First lab sample

84dcf26

Added GH Actions

47209b0

Added step on PR

87ad744

Added sample tests

1b54eb3

Merge branch 'master' of https://github.com/ISUCT/Tprogramming_42_2019

943dce6

Merge branch 'master' into Ksenija_Lizko

a62d862

task A and B

32b7b54

jskonst requested changes Nov 11, 2019

View reviewed changes

исправила без тестов

ddc9ac1

jskonst requested changes Dec 21, 2019

View reviewed changes

Внесла правки по замечаниям

d603784

RinOttawa force-pushed the Ksenija_Lizko branch from 34a600c to d603784 Compare October 14, 2020 00:49

Added unit test, refactored the code

b327fd7

RinOttawa force-pushed the Ksenija_Lizko branch from b327fd7 to d603784 Compare October 14, 2020 00:53

jskonst requested changes Oct 19, 2020

View reviewed changes

Removed unneccessary code, updated the test equations

679bc64

Conversation

RinOttawa commented Nov 2, 2019

Uh oh!

jskonst commented Nov 11, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jskonst commented Nov 25, 2019

Uh oh!

jskonst commented Nov 25, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RinOttawa commented Oct 14, 2020

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants