Kochneva darina alekseevna #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskonst
requested changes
Nov 6, 2022
Comment on lines
+7
to
+14
| [Fact] | ||
| public void RussiaTest() | ||
| { | ||
| var rus = new Russia("Russia", "Moscow", 17000); | ||
| Assert.Equal("Russia", rus.Name); | ||
| Assert.Equal("Moscow", rus.Capital); | ||
| Assert.Equal(17000, rus.Square); | ||
| } |
Contributor
There was a problem hiding this comment.
часть тут можно сократить на inlineData
CourseApp/Canada.cs
Outdated
|
|
||
| public class Canada : Country | ||
| { | ||
| private int positionSq = 2; |
CourseApp/Canada.cs
Outdated
Comment on lines
14
to
17
| public void PositionSquare() | ||
| { | ||
| Console.WriteLine($"{Name} in {positionSq} place in terms of area "); | ||
| } |
Contributor
There was a problem hiding this comment.
а это не должно быть в общем классе?
CourseApp/Country.cs
Outdated
Comment on lines
38
to
46
| /*public void TheCapital() | ||
| { | ||
| Console.WriteLine($"The capital of {Name} is {Capital}"); | ||
| } | ||
|
|
||
| public void Welcome() | ||
| { | ||
| Console.WriteLine($"Welcome to the {Name}! \n"); | ||
| }*/ |
Contributor
There was a problem hiding this comment.
удалите закомментированный код
Contributor
|
Почти ок :) |
Author
|
rpg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Классы и тесты к классам