Engine Refactor #2: Setup Query Parser Test #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinthebomb1
approved these changes
Oct 14, 2025
Collaborator
colinthebomb1
left a comment
colinthebomb1
left a comment
There was a problem hiding this comment.
LGTM! I think this new style is better.
baiqiushi
approved these changes
Oct 15, 2025
Contributor
baiqiushi
left a comment
baiqiushi
left a comment
There was a problem hiding this comment.
LGTM. Let's start with this. The benefit of this structure is the rules.py now looks more like our database. Maybe in the future we can synchronize test rules.py and our Postman tests DB together to maintain the code integrety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines the new
query_parserstructure, sets up test cases, and organizes existing query data withinqueries.py.In the new query parser test file, I replaced the inline-defined queries with ones retrieved from
queries.pyfor efficiency. However, this makes the test cases less intuitive, since we need to refer back toqueries.pyto see which queries are being used. It will be great if I can get some opinions or ideas on whether we should keep the old style (which causes duplication but more friendly to read) or stick with the new style (which is cleaner but less convenient for debugging).