Replace deprecated glassfish files with payara-* files in WEB-INF#12240
Replace deprecated glassfish files with payara-* files in WEB-INF#12240qqmyers wants to merge 4 commits into
Conversation
|
review via Claude - Code Review: PR #12240 — Replace deprecated glassfish files with payara-* files in WEB-INF Author: qqmyers (QDR) Overview Renames glassfish-web.xml → payara-web.xml and glassfish-resources.xml → payara-resources.xml, updating DOCTYPE declarations to reference Payara DTDs. This addresses Payara's deprecation of the Issues
The project uses Payara 7.2026.2, but the PR references Payara 6 DTDs:
The correct references for Payara 7 should be: Using main-6 DTDs will work today (Payara is backward-compatible), but it's misleading and may miss features/validation specific to Payara 7.
The glassfish-resources.xml (now payara-resources.xml) still declares: But the Java source code already uses jakarta.enterprise.concurrent.ManagedExecutorService (as confirmed in S3AccessIO.java, MakeDataCountApi.java, etc.). Payara 7 is Jakarta EE 11 — the javax
The factory class reference is still org.glassfish.resources.custom.factory.ManagedExecutorServiceFactory. This is a Payara-internal class that happens to still exist under the org.glassfish
Two files reference glassfish-web.xml by name in comments:
These should be updated to payara-web.xml for consistency. Correctness The rename itself is straightforward and well-supported by Payara documentation. The root element change ( → ) and corresponding closing tag is required and Risk Assessment Low risk overall. Payara explicitly documents these as supported replacements. The main risk would be if some Payara deployment tooling hardcodes the glassfish-* filenames, but the Payara Testing The PR's testing guidance ("verify Dataverse deploys and runs") is appropriate. Specifically:
Suggestions
Verdict Request changes. The rename is correct in principle but should target Payara 7 DTDs (matching the actual server version) rather than Payara 6 DTDs. The javax → jakarta namespace in resource |
What this PR does / why we need it: Per (Payara)[https://docs.payara.fish/community/docs/Technical%20Documentation/Payara%20Server%20Documentation/Application%20Deployment/Deployment%20Descriptor%20Files.html], the glassfish-web.xml and glassfish-resources,xml file formats we use are deprecated "and support will be removed in a future release". This PR updates to the newer payara* formats - basically a matter of updating the DOCTYPE lines and changing names.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Make sure Dataverse deploy and runs after the update.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: