Skip to content

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Jan 14, 2026

What this PR does / why we need it: This PR makes several improvements to the admin/metadata/reExportAll API call:

  • Fatal run time problems, such as a problem with the database connection (seen at DANS) get logged to the export log before terminating, making it easier to see when there has been a problem
  • a new optional ?olderThan=<YYYY-MM-DD> parameter has been introduced to allow incremental reExportAll, i.e. allowing reExportAll to be done in smaller chunks, or to allow reExporting datasets last updated before some exporter change occurred, or to restart after a failure (use olderThan=)
  • Explicit marking of the overall exportAllDatasets method as not supporting a transaction to avoid pulling all datasets into one transaction (the exportAllFormatsInNewTransaction(dataset) adds datasets to individual transactions as they are processed)
  • Unused fallback code that would write exportLogger info to the main server.log file has been removed

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer: As most of the changes are to error handling or, with the olderThan date param, would require testing over multiple days, I don't see any new tests to add. The existing tests should assure regression testing.

Suggestions on how to test this: Rely on the DatasetsIT tests for regression testing, test performance on large databases (hopefully not having a single overall transaction will noticeably improve memory use/performance). The new olderThan param can be tested on an existing db with a range of lastExport dates. W.r.t. error handling, the only thing I can think to try (if desired) would be to kill the database during a reExportAll run and verify that the export log has logging of that problem. (Would have to restart the db and payara after that I assume.)

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@qqmyers qqmyers added GDCC: DANS related to GDCC work for DANS Size: 3 A percentage of a sprint. 2.1 hours. labels Jan 14, 2026
@qqmyers qqmyers added this to the 6.10 milestone Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GDCC: DANS related to GDCC work for DANS Size: 3 A percentage of a sprint. 2.1 hours.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant