Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR makes several improvements to the admin/metadata/reExportAll API call:
<YYYY-MM-DD>parameter has been introduced to allow incremental reExportAll, i.e. allowing reExportAll to be done in smaller chunks, or to allow reExporting datasets last updated before some exporter change occurred, or to restart after a failure (use olderThan=)Which issue(s) this PR closes:
Special notes for your reviewer: As most of the changes are to error handling or, with the olderThan date param, would require testing over multiple days, I don't see any new tests to add. The existing tests should assure regression testing.
Suggestions on how to test this: Rely on the DatasetsIT tests for regression testing, test performance on large databases (hopefully not having a single overall transaction will noticeably improve memory use/performance). The new olderThan param can be tested on an existing db with a range of lastExport dates. W.r.t. error handling, the only thing I can think to try (if desired) would be to kill the database during a reExportAll run and verify that the export log has logging of that problem. (Would have to restart the db and payara after that I assume.)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: