Add acknowledgment before publishing #12051
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
stevenwinship
added
FY26 Sprint 12
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
talked to @stevenwinship about adding an endpoint to get the disclaimer text to the info API, so it can be read by the SPA |
stevenwinship
moved this from Ready for Review ⏩
to In Progress 💻
in IQSS Dataverse Project
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
pdurbin
reviewed
Jan 14, 2026
| /* | ||
| Publish Disclaimer text. If this setting exists user must acknowledge before a Dataset can be published | ||
| */ | ||
| PublishDatasetDisclaimerText, |
Member
There was a problem hiding this comment.
What's the relationship, if any, between PublishDatasetDisclaimerText and DatasetPublishPopupCustomText? Do we need both?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The repository has been inundated with potential sensitive data and article-only deposits that conflict with the policies and mission.
Depositors should receive an additional confirmation request on publishing, that they acknowledge.
Which issue(s) this PR closes: IQSS/dataverse.harvard.edu#359
Special notes for your reviewer: It was decided not to modify the APIs at this time.
Suggestions on how to test this: Use JSF UI to publish a draft dataset with and without the setting "PublishDatasetDisclaimerText" set. You should see the disclaimer, contained in the setting, when the setting is set and the "Continue" button should be disabled until the checkbox is checked.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: